Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mbed_error: Avoid negative left shift #10395

Merged
merged 1 commit into from Apr 16, 2019

Conversation

Projects
None yet
7 participants
@kjbracey-arm
Copy link
Contributor

commented Apr 12, 2019

Description

User uses of MBED_MAKE_ERROR assemble a new error that gets its bottom 16 bits from an existing negative 32-bit error code. This led to undefined behaviour when << was used on it - even though it was a shift by zero!

Avoid the undefined behaviour warning from Clang by masking before shifting.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@deepakvenugopal, @SenRamakri

mbed_error: Avoid negative left shift
User uses of `MBED_MAKE_ERROR` assemble a new error that gets its bottom
16 bits from an existing negative 32-bit error code. This lead to
undefined behaviour when `<<` was used on it - even though it was a
shift by zero!

Avoid the undefined behaviour warning from Clang by masking before
shifting.

@ciarmcom ciarmcom requested review from deepakvenugopal, SenRamakri and ARMmbed/mbed-os-maintainers Apr 12, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

CI started

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

The CI aborted, will be part of 10394 run

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

CI restarted

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 15, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
@alekla01

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

restarted jenkins-ci/mbed-os-ci_dynamic-memory-usage

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Apr 16, 2019

@0xc0170 0xc0170 merged commit 237bf04 into ARMmbed:master Apr 16, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Success
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8571 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details

@kjbracey-arm kjbracey-arm deleted the kjbracey-arm:mbed_error_warnings branch Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.