mbed_error: Avoid negative left shift #10395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User uses of `MBED_MAKE_ERROR` assemble a new error that gets its bottom 16 bits from an existing negative 32-bit error code. This lead to undefined behaviour when `<<` was used on it - even though it was a shift by zero! Avoid the undefined behaviour warning from Clang by masking before shifting.
|
@kjbracey-arm, thank you for your changes. |
SenRamakri
approved these changes
Apr 12, 2019
deepikabhavnani
approved these changes
Apr 12, 2019
0xc0170
approved these changes
Apr 15, 2019
|
CI started |
|
The CI aborted, will be part of 10394 run |
|
CI restarted |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
|
restarted jenkins-ci/mbed-os-ci_dynamic-memory-usage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
User uses of
MBED_MAKE_ERRORassemble a new error that gets its bottom 16 bits from an existing negative 32-bit error code. This led to undefined behaviour when<<was used on it - even though it was a shift by zero!Avoid the undefined behaviour warning from Clang by masking before shifting.
Pull request type
Reviewers
@deepakvenugopal, @SenRamakri