Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nrf52 memory pools #10733

Merged
merged 5 commits into from Jun 4, 2019

Conversation

Projects
None yet
8 participants
@pan-
Copy link
Member

commented May 31, 2019

Description

Inclusion of #10666 has broken BLE on NRF52_DK. This patch also reduce the RAM necessary to run BLE on NRF52XXX targets.

  • NRF52_DK: 3.3K of RAM saved
  • NRF52840_DK: ~39K of RAM saved.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@LDong-Arm @paul-szczepanek-arm @donatieng

Release Notes

@ciarmcom ciarmcom requested review from donatieng, LDong-Arm, paul-szczepanek-arm and ARMmbed/mbed-os-maintainers May 31, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented May 31, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

5.13.1 labeled (if this should be in the next RC, let us know)

@0xc0170

0xc0170 approved these changes Jun 3, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

5.13.1 labeled (if this should be in the next RC, let us know)

rc2 to address this issue in rc1

cc @adbridge

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

I started the CI job meanwhile

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

CI failed to check-out, we are investigating

cc @ARMmbed/mbed-os-test

@donatieng
Copy link
Member

left a comment

Looks good, thanks @pan-

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jun 3, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

CI restarted. S3 issues appear addressed.

@mbed-ci

This comment has been minimized.

Copy link

commented Jun 3, 2019

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 6
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
@bulislaw
Copy link
Member

left a comment

Approved for RC2

@0xc0170 0xc0170 added needs: work and removed needs: CI labels Jun 4, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

IAR reports build failures

ToolException: 
    l2cRegCb_t          regCb[L2C_COC_REG_MAX];   /* Registration control blocks */
                        ^
"/builds/ws/mbed-os-ci_build-IAR@4/mbed-os/features/FEATURE_BLE/targets/TARGET_CORDIO/stack/ble-host/sources/stack/l2c/l2c_coc.c",135  Error[Pe070]: incomplete type is not allowed

    l2cChanCb_t         chanCb[L2C_COC_CHAN_MAX]; /* Channel control blocks */
                        ^
"/builds/ws/mbed-os-ci_build-IAR@4/mbed-os/features/FEATURE_BLE/targets/TARGET_CORDIO/stack/ble-host/sources/stack/l2c/l2c_coc.c",137  Error[Pe070]: incomplete type is not allowed

    for (i = 0; i < L2C_COC_REG_MAX; i++, pCb++)

Please review

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

Does L2C_COC_CHAN_MAX need to be 0 ? It produces warnings in comparisons (against 0) plus incomplete type above

@pan-

This comment has been minimized.

Copy link
Member Author

commented Jun 4, 2019

Looks like a value of 1 would be more adequate in this PR then.
A value of 0 should be allowed; let see what we can do after the release.

@paul-szczepanek-arm

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

does it matter though? we don't use that feature, I assume no allocations take place

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

Once updated, let us know, will restart testing

Cordio: Fix default COC parameters.
The stack doesn't cope with zero COC client or channel on IAR.
@pan-

This comment has been minimized.

Copy link
Member Author

commented Jun 4, 2019

@0xc0170 Updated.

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Jun 4, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

CI restarted

@mbed-ci

This comment has been minimized.

Copy link

commented Jun 4, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 7
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jun 4, 2019

@0xc0170 0xc0170 merged commit fbc489e into ARMmbed:master Jun 4, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+4488 bytes) RAM(+17104 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8573 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details

@0xc0170 0xc0170 removed the ready for merge label Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.