-
Notifications
You must be signed in to change notification settings - Fork 3k
Add OKDO platform #11407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OKDO platform #11407
Conversation
@mahanthgouda, thank you for your changes. |
SWCLK = PA_14, | ||
NTRST = PB_4, | ||
|
||
// MTB Aliases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are this commented out?
Hi Martin,
I believe this is not needed anymore.
Hence commented out.
Thanks,
Mahanth
…On Wed, Sep 4, 2019 at 8:29 AM Martin Kojtal ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In
targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F439xI/TARGET_MODULE_UBLOX_ODIN_W2/TARGET_OKDO_UBLOX_ODIN_W2/PinNames.h
<#11407 (comment)>:
> +#ifdef MBED_CONF_TARGET_STDIO_UART_RX
+ STDIO_UART_RX = MBED_CONF_TARGET_STDIO_UART_RX,
+#elif MBED_CONF_TARGET_USB_RX
+ STDIO_UART_TX = MBED_CONF_TARGET_USB_RX,
+#else
+ STDIO_UART_RX = PA_10,
+#endif
+
+ // DAPLink
+ USBRX = STDIO_UART_RX,
+ USBTX = STDIO_UART_TX,
+ SWDIO = PA_15,
+ SWCLK = PA_14,
+ NTRST = PB_4,
+
+ // MTB Aliases
why are this commented out?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11407?email_source=notifications&email_token=AJQMTSBYRY5JVDJDXX2XWYTQH5PWBA5CNFSM4ITLGQMKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDSKZEA#pullrequestreview-283421840>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJQMTSGYCLNH4LIAZP76M3TQH5PWBANCNFSM4ITLGQMA>
.
|
If that is the case, please remove it. Not needed in the file |
Done, thanks.
…On Wed, Sep 4, 2019 at 12:51 PM Martin Kojtal ***@***.***> wrote:
If that is the case, please remove it. Not needed in the file
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11407?email_source=notifications&email_token=AJQMTSC5OV2UMKJIUFR75ZTQH6OMPA5CNFSM4ITLGQMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD53JXBY#issuecomment-527866759>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJQMTSFWXJ2VJJFDRGZ2DSLQH6OMPANCNFSM4ITLGQMA>
.
|
@mahanthgouda There are ARMC6 failures there in the logs regarding networking - are these known issue with Odin - I dont think so. Please clarify |
These are not known issues, however they are expected to fail because I
tried to run them on the hotspot.
But these tests have passed on other Compilers, so I believe they should be
OK.
…On Thu, Sep 5, 2019 at 10:06 AM Martin Kojtal ***@***.***> wrote:
@mahanthgouda <https://github.com/mahanthgouda> There are ARMC6 failures
there in the logs regarding networking - are these known issue with Odin -
I dont think so. Please clarify
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11407?email_source=notifications&email_token=AJQMTSBHXSHMYQO3OMBNGHDQIDDZVA5CNFSM4ITLGQMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD56M5UI#issuecomment-528273105>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJQMTSAXJZA7YMWOEBBK4CDQIDDZVANCNFSM4ITLGQMA>
.
|
CI restarted |
Test run: FAILEDSummary: 3 of 4 test jobs failed Failed test jobs:
|
Please review build artifacts, there are build failures related to this PR |
@mahanthgouda can you please make the suggested changes? @0xc0170 I'm not entirely sure why the CI failed - I tried locally and built fine - we should keep an eye on this |
We figured this out. The branch is not rebased to the latest master. Once you do, you should be to reproduce the error - ublox updated odin drivers plus also fixed ADC issue (the one failing here). Please rebase and fix ADC pinout. |
This is the PR for ADC: #11266 |
e40bf30
to
a978c39
Compare
PR rebased. @mahanthgouda please fetch your branch again, and fix ADC pins - you should be able to reproduce the issue we are seeing |
…da/mbed-os into OKDO_UBLOX_ODIN_W2_V1
We shall squash this before merging cc @ARMmbed/mbed-os-maintainers |
CI started |
Test run: FAILEDSummary: 1 of 4 test jobs failed Failed test jobs:
|
CI restarted |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Because of the messy commit history on this PR it is proving impossible to cherry-pick across to the 5.14 branch. I will see if I can manually add this across, if that is too much work then this will thus have to be punted to a future release. |
Description
Adding OKdo platform
Green tea test logs attached
OKDO_ARMC6_log.txt
OKDO_GCC_ARM_log.txt
OKDO_ARMC5_log.txt
Pull request type
Reviewers
Release Notes
@MarceloSalazar