Skip to content

Add OKDO platform #11407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Sep 16, 2019
Merged

Add OKDO platform #11407

merged 14 commits into from
Sep 16, 2019

Conversation

mahanthgouda
Copy link
Contributor

Description

Adding OKdo platform
Green tea test logs attached
OKDO_ARMC6_log.txt
OKDO_GCC_ARM_log.txt
OKDO_ARMC5_log.txt

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@MarceloSalazar

@ciarmcom ciarmcom requested review from MarceloSalazar and a team September 3, 2019 23:00
@ciarmcom
Copy link
Member

ciarmcom commented Sep 3, 2019

@mahanthgouda, thank you for your changes.
@MarceloSalazar @ARMmbed/mbed-os-maintainers please review.

SWCLK = PA_14,
NTRST = PB_4,

// MTB Aliases
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are this commented out?

@mahanthgouda
Copy link
Contributor Author

mahanthgouda commented Sep 4, 2019 via email

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 4, 2019

If that is the case, please remove it. Not needed in the file

@mahanthgouda
Copy link
Contributor Author

mahanthgouda commented Sep 4, 2019 via email

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 5, 2019

@mahanthgouda There are ARMC6 failures there in the logs regarding networking - are these known issue with Odin - I dont think so. Please clarify

@mahanthgouda
Copy link
Contributor Author

mahanthgouda commented Sep 5, 2019 via email

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 5, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Sep 5, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 5, 2019

Please review build artifacts, there are build failures related to this PR

@MarceloSalazar
Copy link

@mahanthgouda can you please make the suggested changes?

@0xc0170 I'm not entirely sure why the CI failed - I tried locally and built fine - we should keep an eye on this

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 12, 2019

We figured this out. The branch is not rebased to the latest master. Once you do, you should be to reproduce the error - ublox updated odin drivers plus also fixed ADC issue (the one failing here). Please rebase and fix ADC pinout.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 12, 2019

This is the PR for ADC: #11266

@0xc0170 0xc0170 force-pushed the OKDO_UBLOX_ODIN_W2_V1 branch from e40bf30 to a978c39 Compare September 12, 2019 08:46
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 12, 2019

PR rebased. @mahanthgouda please fetch your branch again, and fix ADC pins - you should be able to reproduce the issue we are seeing

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 16, 2019

We shall squash this before merging

cc @ARMmbed/mbed-os-maintainers

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 16, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 16, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 16, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Sep 16, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 5
Build artifacts

@0xc0170 0xc0170 merged commit 1780a08 into ARMmbed:master Sep 16, 2019
@adbridge
Copy link
Contributor

adbridge commented Oct 14, 2019

Because of the messy commit history on this PR it is proving impossible to cherry-pick across to the 5.14 branch. I will see if I can manually add this across, if that is too much work then this will thus have to be punted to a future release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants