Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upInitial addition of files to support CY8CKIT_064S2_4343W target #11434
Conversation
This comment has been minimized.
This comment has been minimized.
For new targets, please attach testing logs |
This comment has been minimized.
This comment has been minimized.
@romanjoe, thank you for your changes. |
This comment has been minimized.
This comment has been minimized.
@romanjoe Sharing the tests here? please attach them |
This comment has been minimized.
This comment has been minimized.
I started CI meanwhile |
This comment has been minimized.
This comment has been minimized.
mbed-ci
commented
Sep 9, 2019
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
This comment has been minimized.
This comment has been minimized.
@romanjoe Please provide test results |
This comment has been minimized.
This comment has been minimized.
Once done, this shall be ready for integration |
edea012
to
b2c1855
This comment has been minimized.
This comment has been minimized.
b2c1855
to
ee922a6
This comment has been minimized.
This comment has been minimized.
8797956
to
e939430
This comment has been minimized.
This comment has been minimized.
Tests run log added to header. @0xc0170 @maclobdell - could you please run CI and proceed with merging this PR. |
This comment has been minimized.
This comment has been minimized.
We don't need this one, as stated above? If not, we can run CI! |
This comment has been minimized.
This comment has been minimized.
@0xc0170 that one 11504 is not critical for this PR, so you can proceed with CI run. Thank you. |
Please confirm - is QSPIF possible on this board? is the supervisory flash area used in normal operation? If so, can the bootloader support that? |
targets/TARGET_Cypress/TARGET_PSOC6/TARGET_CY8CKIT_064S2_4343W/PinNames.h
Show resolved
Hide resolved
...C6/TARGET_CY8CKIT_064S2_4343W/device/TOOLCHAIN_ARM/cyb06xxa_cm4_dual.sct
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
Hi @0xc0170, @maclobdell has approved the code, could you please run the CI to finalize this PR? Thank you! |
This comment has been minimized.
This comment has been minimized.
@maclobdell Hi Mac, in current implementation this one depends on #11504, but since status and resolution of 11504 is not clear right now i can make a little tweak (it is ready, just need to push) to make this one work without 11504 to align implementation with existing CY8CKIT_062_WIFI_BT and we would be able to push this one forward. In case 11504 would be merged - all existing targets would need update anyways. |
4b42f58
to
9b86b39
This comment has been minimized.
This comment has been minimized.
@maclobdell i made required changes - now this PR in independent |
This comment has been minimized.
This comment has been minimized.
CI started |
This comment has been minimized.
This comment has been minimized.
mbed-ci
commented
Oct 14, 2019
Test run: FAILEDSummary: 3 of 4 test jobs failed Failed test jobs:
|
This comment has been minimized.
This comment has been minimized.
[ERROR] PSOC6.sign_image finished execution with errors! Signature is not added |
This comment has been minimized.
This comment has been minimized.
@jussisip could you check the CI scripts. I cannot find any problem in the logic. |
This comment has been minimized.
This comment has been minimized.
@romanjoe This is pretty unclear case how it fails. This is handled similar way than CY8CPROTO_064_SB which works well. But in this happens:
First line comes from mbed-os/tools/targets/PSOC6.py Line 382 in 079564b The key question is that what is so different in this than CY8CPROTO_064_SB that this cannot work? Wifi example build works well with CY8CPROTO_064_SB. |
This comment has been minimized.
This comment has been minimized.
@maclobdell can you chase this up please. This will now be bumped to 5.14.2 |
This comment has been minimized.
This comment has been minimized.
Hi @OPpuolitaival, Problem with mbed-os-example-wifi raises because of lack of flash for this example. I suppose you would be able to find message similar to this:
This message comes from tool that adds cryptographic signature to compiled image. This tool has set of parameters used for adding signature. One of them is a slot size used by Cypressbootloader for boot. This value is set in policy file - mbed-os/targets/TARGET_Cypress/TARGET_PSOC6/sb-tools/policy/policy_single_stage_CM4.json and equals 0x50000. There should be 2 slots of this size to enable upgrade possibility using UPGRADE slot. CY8CPROTO_064_SB target has no connectivity (thus no wifi/bt code compiled and included to hex file) and 1M of flash overall. So it can fit 2 slots of size 0x50000 (considering flash alignments restrictions and memory protection configuration restrictions). CY8CKIT_064S2_4343W uses same policy file and slot sizes, but has wifi/bt and as result much bigger hex file, than 0x50000. Since this board has 2M of flash - slot sizes can be stretched to fit bigger hex file. This described in Secure Boot user guide and Readme.md in mbed-os/targets/TARGET_Cypress/TARGET_PSOC6/sb-tools (https://www.cypress.com/secureboot-sdk-user-guide). As a solution for CI i can add additional file to mbed-os/targets/TARGET_Cypress/TARGET_PSOC6/sb-tools/policy, with stretched bootloader slots sizes to use with CY8CKIT_064S2_4343W. |
This comment has been minimized.
This comment has been minimized.
Probably we can limit mbed-os/tools/test/examples/examples.json Line 120 in c94ae90 |
This comment has been minimized.
This comment has been minimized.
@OPpuolitaival did you try to build wifi example with latest changes i made yesterday? i was able to compile and get image signed successfully with new policy file. actually having this new file as template for 2M board would provide better user experience with no need to read User Guide immediately after getting started |
This comment has been minimized.
This comment has been minimized.
CI restarted |
This comment has been minimized.
This comment has been minimized.
mbed-ci
commented
Oct 16, 2019
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
romanjoe commentedSep 6, 2019
•
edited
Description
This PR brings support for new Cypress target in mbed-os - CY8CKIT_064S2_4343W.
PR includes all necessary files to integrate target with mbed-os build system and post build actions.
Tests run logs:
LIN_064S2_ARMC6_bg.txt
LIN_064S2_GCC_ARM_bg.txt
MAC_064S2_GCC_ARM_bg.txt
WIN_064S2_ARMC6_bg.txt
WIN_064S2_GCC_ARM_bg.txt
WIN_064S2_IAR_bg.txt
Pull request type
Reviewers
Release Notes