-
Notifications
You must be signed in to change notification settings - Fork 3k
Remove deprecated connectivity examples #14109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@paul-szczepanek-arm, thank you for your changes. |
5e6197b
to
41fbfac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
summarising discussion related to the deprecation
-
mbed-os-example-wifi is getting deprecated. mbed-os-ci currently tests network scanning in mbed-os-example-wifi. mbed-os-example-sockets will include wifi tests but cannot test just the scanning. Since, RAAS doesn’t have devices with wifi connectivity mbed-os-example-sockets cannot be tested with Wifi.
-
mbed-os-example-tls-socket is getting depcrated. The features are tested by mbed-os-example-tls
I don't see any note about being deprecated (i've checked https://github.com/ARMmbed/mbed-os-example-tls-socket). Should we first fix this in examples then proceed with this PR? |
Please rebase to the latest master, it will fix travis error. |
41fbfac
to
497504d
Compare
rebased |
I found ARMmbed/mbed-os-example-tls-socket#67 , when this will be merged (how to coordinate this PR with PR examples) ? |
CI started |
it's a bit chicken and egg but I guess I'll merge the notice first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, have you checked in the documentation and website for references to this example ?
Quote from wifi example PR (ARMmbed/mbed-os-example-wifi#206) - docs also updated? website (we published this also to mbed.com or?) ?
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
This is ready almost. @paul-szczepanek-arm just confirm the examples were deprecated, documentation in our docs was updated, Ci tests covered here. Anything else to cover? |
removed it from docs: ARMmbed/mbed-os-5-docs#1393 |
Summary of changes
These examples have been deprecated (merged into sockets) so should be removed
Impact of changes
Migration actions required
Documentation
none
Pull request type
Test results
Reviewers
@saheerb