Skip to content

Remove deprecated connectivity examples #14109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

paul-szczepanek-arm
Copy link
Member

@paul-szczepanek-arm paul-szczepanek-arm commented Jan 4, 2021

Summary of changes

These examples have been deprecated (merged into sockets) so should be removed

Impact of changes

Migration actions required

Documentation

none


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@saheerb


@ciarmcom ciarmcom requested review from saheerb and a team January 4, 2021 12:30
@ciarmcom
Copy link
Member

ciarmcom commented Jan 4, 2021

@paul-szczepanek-arm, thank you for your changes.
@saheerb @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@saheerb saheerb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

summarising discussion related to the deprecation

  • mbed-os-example-wifi is getting deprecated. mbed-os-ci currently tests network scanning in mbed-os-example-wifi. mbed-os-example-sockets will include wifi tests but cannot test just the scanning. Since, RAAS doesn’t have devices with wifi connectivity mbed-os-example-sockets cannot be tested with Wifi.

  • mbed-os-example-tls-socket is getting depcrated. The features are tested by mbed-os-example-tls

@pan- pan- changed the title Remove deprecated examples Remove deprecated connectivity examples Jan 4, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 5, 2021

I don't see any note about being deprecated (i've checked https://github.com/ARMmbed/mbed-os-example-tls-socket). Should we first fix this in examples then proceed with this PR?

@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Jan 5, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 5, 2021

Please rebase to the latest master, it will fix travis error.

@paul-szczepanek-arm
Copy link
Member Author

rebased

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 11, 2021

I found ARMmbed/mbed-os-example-tls-socket#67 , when this will be merged (how to coordinate this PR with PR examples) ?

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 11, 2021

CI started

@paul-szczepanek-arm
Copy link
Member Author

it's a bit chicken and egg but I guess I'll merge the notice first

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, have you checked in the documentation and website for references to this example ?

Quote from wifi example PR (ARMmbed/mbed-os-example-wifi#206) - docs also updated? website (we published this also to mbed.com or?) ?

@mbed-ci
Copy link

mbed-ci commented Jan 11, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 11, 2021

This is ready almost. @paul-szczepanek-arm just confirm the examples were deprecated, documentation in our docs was updated, Ci tests covered here. Anything else to cover?

@paul-szczepanek-arm
Copy link
Member Author

removed it from docs: ARMmbed/mbed-os-5-docs#1393

@0xc0170 0xc0170 merged commit 830f82c into ARMmbed:master Jan 14, 2021
@mergify mergify bot removed the ready for merge label Jan 14, 2021
@mbedmain mbedmain added release-version: 6.7.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants