STM: SPI: Initialize Rx in spi_master_write #3540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case Rx is not initiliased its content might be random from stack. This is causing problem in case of 8 bits read only as the left-side 8 bits of the returned int value may contain this random byte data. This was for instance detected when using SDFileSystem Lib.
|
/morph test |
0xc0170
approved these changes
Jan 6, 2017
bridadan
approved these changes
Jan 6, 2017
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
aisair
pushed a commit
to aisair/mbed
that referenced
this pull request
Apr 30, 2024
Ports for Upcoming Targets Fixes and Changes 3488: Dev stm i2c v2 unitary functions ARMmbed/mbed-os#3488 3492: Fix #3463 CAN read() return value ARMmbed/mbed-os#3492 3503: [LPC15xx] Ensure that PWM=1 is resolved correctly ARMmbed/mbed-os#3503 3504: [LPC15xx] CAN implementation improvements ARMmbed/mbed-os#3504 3539: NUCLEO_F412ZG - Add support of TRNG peripheral ARMmbed/mbed-os#3539 3540: STM: SPI: Initialize Rx in spi_master_write ARMmbed/mbed-os#3540 3438: K64F: Add support for SERIAL ASYNCH API ARMmbed/mbed-os#3438 3519: MCUXpresso: Fix ENET driver to enable interrupts after interrupt handler is set ARMmbed/mbed-os#3519 3544: STM32L4 deepsleep improvement ARMmbed/mbed-os#3544 3546: NUCLEO-F412ZG - Add CAN peripheral ARMmbed/mbed-os#3546 3551: Fix I2C driver for RZ/A1H ARMmbed/mbed-os#3551 3558: K64F UART Asynch API: Fix synchronization issue ARMmbed/mbed-os#3558 3563: LPC4088 - Fix vector checksum ARMmbed/mbed-os#3563 3567: Dev stm32 F0 v1.7.0 ARMmbed/mbed-os#3567 3577: Fixes linking errors when building with debug profile ARMmbed/mbed-os#3577
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an SPI issue as reported here: #3501
Also applicable to other NUCLEO boards tested on -ci-test-shield
Note:
To have the test completely PASS on NUCLEO_L476RG, this PR on ci-test-shield repo is also needed ARMmbed/ci-test-shield#21
Otherwise the test would fail at the "SPI - Object Definable" step.
Description
In case Rx is not initialized its content might be random from stack.
This is causing problem in case of 8 bits read only as the left-side 8 bits
of the returned int value may contain this random byte data. This was for
instance detected when using SDFileSystem Lib.
Status
READY
Tests results
+-----------------------+---------------+---------------+------------------------+--------+--------+--------+--------------------+
| target | platform_name | test suite | test case | passed | failed | result | elapsed_time (sec) |
+-----------------------+---------------+---------------+------------------------+--------+--------+--------+--------------------+
| NUCLEO_L476RG-GCC_ARM | NUCLEO_L476RG | tests-api-spi | SPI - Object Definable | 1 | 0 | OK | 0.05 |
| NUCLEO_L476RG-GCC_ARM | NUCLEO_L476RG | tests-api-spi | SPI - SD Read | 1 | 0 | OK | 0.25 |
| NUCLEO_L476RG-GCC_ARM | NUCLEO_L476RG | tests-api-spi | SPI - SD Write | 1 | 0 | OK | 0.51 |
| NUCLEO_L476RG-GCC_ARM | NUCLEO_L476RG | tests-api-spi | SPI - SD card exists | 1 | 0 | OK | 0.44 |
+-----------------------+---------------+---------------+------------------------+--------+--------+--------+--------------------+
+-----------------------+---------------+---------------+------------------------+--------+--------+--------+--------------------+
| target | platform_name | test suite | test case | passed | failed | result | elapsed_time (sec) |
+-----------------------+---------------+---------------+------------------------+--------+--------+--------+--------------------+
| NUCLEO_F410RB-GCC_ARM | NUCLEO_F410RB | tests-api-spi | SPI - Object Definable | 1 | 0 | OK | 0.05 |
| NUCLEO_F410RB-GCC_ARM | NUCLEO_F410RB | tests-api-spi | SPI - SD Read | 1 | 0 | OK | 0.21 |
| NUCLEO_F410RB-GCC_ARM | NUCLEO_F410RB | tests-api-spi | SPI - SD Write | 1 | 0 | OK | 0.42 |
| NUCLEO_F410RB-GCC_ARM | NUCLEO_F410RB | tests-api-spi | SPI - SD card exists | 1 | 0 | OK | 0.71 |
+-----------------------+---------------+---------------+------------------------+--------+--------+--------+--------------------+