Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K64F UART Asynch API: Fix synchronization issue #3558

Merged
merged 1 commit into from
Jan 13, 2017

Conversation

mmahadevan108
Copy link
Contributor

Description

This PR fixes the issues highlighted in the below issue:
#3535

Status

**READY

  • Tests
    Ran the test that was included in the PR, below is the output:
    Hello and welcome to serial DMA fun!

-------- dma_serial_write_async_without_dma -------Howdy

Congratulations! You've made it through the gauntlet!

    Sorry, looks like we hung.

The last line is printed even for a pass as it is the result of a 2 second timer that is activated in the test

The UART state should be set to busy before starting the transfer

Signed-off-by: Mahadevan Mahesh <Mahesh.Mahadevan@nxp.com>
@bridadan
Copy link
Contributor

Thanks for the PR @mmahadevan108!

/morph test

@bridadan
Copy link
Contributor

@Patater Would you mind verifying that this patch fixes your issue #3535?

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1375

All builds and test passed!

@bridadan
Copy link
Contributor

@VeliMattiLahtela Looks like mbed-os-cliapp step failed again with Couldn’t allocate all required devices. Restarting now.

@Patater
Copy link
Contributor

Patater commented Jan 11, 2017

Tested working on K64F.

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@bridadan
Copy link
Contributor

@VeliMattiLahtela @jupe @mazimkhan @miklis @adbridge Trying to restart the Oulu CI and the GitHub rate limit has been exceeded (again), causing the job to fail immediately. This is blocking this and many other PRs from getting merged in. Can we please use a separate GitHub account for the Oulu CI and the Cambridge CI so we distribute the number of requests better? I would suggest giving @ciarmcom to the Oulu team and creating a new account for the Cambridge CI.

@miklis
Copy link
Contributor

miklis commented Jan 16, 2017

@bridadan We have just recently added one more account to the CI but have not yet configured that for mbed-os. I'll do it today, so ciarmcom account will be used only by Cambridge CI. Additionally we are expecting a fix to Jenkins, that should be available in January https://issues.jenkins-ci.org/browse/JENKINS-36121

@bridadan
Copy link
Contributor

@miklis Thanks very much for the update and for tackling this problem, I know how frustrating this can be!

@mmahadevan108 mmahadevan108 deleted the UART_Asynch_Fix branch January 20, 2017 14:43
aisair pushed a commit to aisair/mbed that referenced this pull request Apr 30, 2024
Ports for Upcoming Targets


Fixes and Changes

3488: Dev stm i2c v2 unitary functions ARMmbed/mbed-os#3488
3492: Fix #3463 CAN read() return value ARMmbed/mbed-os#3492
3503: [LPC15xx] Ensure that PWM=1 is resolved correctly ARMmbed/mbed-os#3503
3504: [LPC15xx] CAN implementation improvements ARMmbed/mbed-os#3504
3539: NUCLEO_F412ZG - Add support of TRNG peripheral ARMmbed/mbed-os#3539
3540: STM: SPI: Initialize Rx in spi_master_write ARMmbed/mbed-os#3540
3438: K64F: Add support for SERIAL ASYNCH API ARMmbed/mbed-os#3438
3519: MCUXpresso: Fix ENET driver to enable interrupts after interrupt handler is set ARMmbed/mbed-os#3519
3544: STM32L4 deepsleep improvement ARMmbed/mbed-os#3544
3546: NUCLEO-F412ZG - Add CAN peripheral ARMmbed/mbed-os#3546
3551: Fix I2C driver for RZ/A1H ARMmbed/mbed-os#3551
3558: K64F UART Asynch API: Fix synchronization issue ARMmbed/mbed-os#3558
3563: LPC4088 - Fix vector checksum ARMmbed/mbed-os#3563
3567: Dev stm32 F0 v1.7.0 ARMmbed/mbed-os#3567
3577: Fixes linking errors when building with debug profile ARMmbed/mbed-os#3577
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants