New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

u-blox rearrange ODIN target #4510

Merged
merged 1 commit into from Jun 15, 2017

Conversation

Projects
None yet
6 participants
@kegilbert
Contributor

kegilbert commented Jun 9, 2017

Changed cherry-picking of #4089 from original PR (#4467).

No one assigned yet as reviewer, wanted to get a CI run through to see if this helped anything.


Rebase against master for: #4089

Smaller chunk of the Workshop branch additions: #4412

Feel free to add in however else should be a reviewer @c1728p9

@kegilbert kegilbert added the needs: CI label Jun 9, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 9, 2017

The first jenkins CI failed with

[UBLOX_EVK_ODIN_W2_armcc_wlan0] Error: L6218E: Undefined symbol SDIO_DataConfig (referred from cb_mmc.o).
01:04:03 [UBLOX_EVK_ODIN_W2_armcc_wlan0] Finished: 0 information, 0 warning and 1 error messages.
01:04:03 [UBLOX_EVK_ODIN_W2_armcc_wlan0] [ERROR] Error: L6218E: Undefined symbol SDIO_DataConfig (referred from cb_mmc.o).
01:04:03 [UBLOX_EVK_ODIN_W2_armcc_wlan0] Finished: 0 information, 0 warning and 1 error messages.
01:04:03 [UBLOX_EVK_ODIN_W2_armcc_wlan0] 

Please have a look ( I retriggered the build to confirm this).

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 9, 2017

@kegilbert

This comment has been minimized.

Contributor

kegilbert commented Jun 9, 2017

Seems to be the same error as before (#4467). Thanks for checking up on it and CCing @0xc0170!

@andreaslarssonublox

This comment has been minimized.

Contributor

andreaslarssonublox commented Jun 12, 2017

Most likely the binaries for the ODIN driver are the old ones.
@kegilbert Could you check to see if this string "odin_driver_os_5_v2.0_rc1" is present in the binary otherwise it's probably an old binary.
Binaries:
TARGET_UBLOX_EVK_ODIN_W2\sdk\TOOLCHAIN_ARM\libublox-odin-w2-driver.ar
TARGET_UBLOX_EVK_ODIN_W2\sdk\TOOLCHAIN_GCC_ARM\libublox-odin-w2-driver.a
TARGET_UBLOX_EVK_ODIN_W2\sdk\TOOLCHAIN_IAR\libublox-odin-w2-driver.a

@kegilbert

This comment has been minimized.

Contributor

kegilbert commented Jun 12, 2017

@andreaslarssonublox TARGET_UBLOX_EVK_ODIN_W2\sdk\TOOLCHAIN_GCC_ARM\libublox-odin-w2-driver.a contained that version string, but the other two binaries did not.

@kegilbert kegilbert force-pushed the kegilbert:rearrange-odin-target-rebase branch to 6a270fb Jun 14, 2017

@kegilbert kegilbert changed the title from u-blox rearrange ODIN target - Rebase [2] to u-blox rearrange ODIN target Jun 14, 2017

@kegilbert kegilbert requested review from 0xc0170, c1728p9 and theotherjimmy and removed request for 0xc0170 Jun 14, 2017

@kegilbert

This comment has been minimized.

Contributor

kegilbert commented Jun 14, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Jun 15, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 554

All builds and test passed!

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 15, 2017

@kegilbert @andreaslarssonublox I just checked all three binaries, and they have the string "odin_driver_os_5_v2.0_rc1 (as part of a file string E:\build_odin_driver_os_5_v2.0_rc1\ublox-odin-w2-drivers-confidential\source\cb_wlan\common\cb_version.c). That should be fine.

@sg- sg- merged commit 226af54 into ARMmbed:master Jun 15, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sg- sg- removed the ready for merge label Jun 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment