New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32 UART init update #5570

Merged
merged 3 commits into from Jan 4, 2018

Conversation

Projects
None yet
7 participants
@jeromecoutant
Contributor

jeromecoutant commented Nov 23, 2017

Description

  • serial_init, serial_free and serial_baud functions moved from serial_device.c (specific to each STM32 family) to serial_api.c (common STM32 file)

  • default baudrate value was hardcoded to 9600

    • Value is set now to MBED_CONF_PLATFORM_STDIO_BAUD_RATE for STDIO
    • Value is set now to MBED_CONF_PLATFORM_DEFAULT_SERIAL_BAUD_RATE for other use
  • UART init will not be stopped before calling serial_baud function

  • for LPUART, init procedure can update the clock source depending on expected baudrate

This should close #5389 issue

Status

READY

Tests

OS2 and OS5 tests verified for all STM32 targets

jeromecoutant added some commits Nov 21, 2017

STM32 UART init update
- serial_init, serial_free and serial_baud function moved from serial_device.c (specific to each STM32 family) to serial_api.c (common STM32 file)
- default baudrate value was hardcoded to 9600
  - Value is set now to MBED_CONF_PLATFORM_STDIO_BAUD_RATE for STDIO
  - Value is set now to MBED_CONF_PLATFORM_DEFAULT_SERIAL_BAUD_RATE for other use
- UART init will not be stopped before calling serial_baud function
#if defined (TARGET_STM32F091RC)
#define UART_NUM (8)
#if defined (TARGET_STM32F031K6)
#define UART_NUM (1

This comment has been minimized.

@bcostm

bcostm Nov 24, 2017

Contributor

a parenthesis is missing ?

This comment has been minimized.

@jeromecoutant

jeromecoutant Nov 24, 2017

Contributor

yes, I didn't see this build failure in the non reg tests... :-(

#define UART_NUM (6)
#elif defined (TARGET_STM32F429xI) || defined (TARGET_STM32F439xI) || defined (TARGET_STM32F437xG) || defined (TARGET_STM32F469xI)
#define UART_NUM (8)
#elif defined (TARGET_STM32F413xH)

This comment has been minimized.

@bcostm

bcostm Nov 24, 2017

Contributor

maybe merge this #elif and the #else below ?

This comment has been minimized.

@jeromecoutant

jeromecoutant Nov 24, 2017

Contributor

done

// #include "cmsis.h"

This comment has been minimized.

@bcostm

bcostm Nov 24, 2017

Contributor

remove this dead code ?

This comment has been minimized.

@jeromecoutant

jeromecoutant Nov 24, 2017

Contributor

done

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 24, 2017

@jeromecoutant Please look at travis failure, related to the changesets

@0xc0170 0xc0170 added needs: work and removed needs: review labels Nov 24, 2017

@jeromecoutant

Updates done (Travis will also be OK)
Thx for the code review

#if defined (TARGET_STM32F091RC)
#define UART_NUM (8)
#if defined (TARGET_STM32F031K6)
#define UART_NUM (1

This comment has been minimized.

@jeromecoutant

jeromecoutant Nov 24, 2017

Contributor

yes, I didn't see this build failure in the non reg tests... :-(

#define UART_NUM (6)
#elif defined (TARGET_STM32F429xI) || defined (TARGET_STM32F439xI) || defined (TARGET_STM32F437xG) || defined (TARGET_STM32F469xI)
#define UART_NUM (8)
#elif defined (TARGET_STM32F413xH)

This comment has been minimized.

@jeromecoutant

jeromecoutant Nov 24, 2017

Contributor

done

// #include "cmsis.h"

This comment has been minimized.

@jeromecoutant

jeromecoutant Nov 24, 2017

Contributor

done

@0xc0170 0xc0170 added needs: review and removed needs: work labels Nov 24, 2017

@bcostm

bcostm approved these changes Nov 24, 2017

@theotherjimmy theotherjimmy requested a review from 0xc0170 Nov 27, 2017

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Dec 5, 2017

/morph test

@0xc0170

0xc0170 approved these changes Dec 5, 2017

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Dec 5, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 5, 2017

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Dec 5, 2017

Build : SUCCESS

Build number : 655
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5570/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@kegilbert

This comment has been minimized.

Contributor

kegilbert commented Dec 6, 2017

We have seen related test failures intermittently, retesting to confirm.
/morph test

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 7, 2017

@jeromecoutant Getting a failure that we have seen earlier :/ Do you have the target to reproduce this failure?

/morph test

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Dec 7, 2017

Failure is not related to the PR... it is a known issue: #5622

@mbed-ci

This comment has been minimized.

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Dec 13, 2017

Could this PR be merged ?
Thx

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 13, 2017

/morph build

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 14, 2017

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Dec 14, 2017

Build : SUCCESS

Build number : 699
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5570/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 14, 2017

The failure is known, being investigated, hopefully resolved soon

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Dec 14, 2017

The failure is known,

So it can be merged ? :-)

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 15, 2017

Green policy here 🍏 📗 needs to get green

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 22, 2017

/morph test

@mbed-ci

This comment has been minimized.

@adbridge

This comment has been minimized.

Contributor

adbridge commented Dec 29, 2017

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 3, 2018

Needs to be rebuild I believe

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 3, 2018

Build : SUCCESS

Build number : 783
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5570/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 3, 2018

🍏 Green !

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jan 3, 2018

@theotherjimmy theotherjimmy merged commit 62a7ecd into ARMmbed:master Jan 4, 2018

6 checks passed

AWS-CI uVisor Build & Test Verification build successful.
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jeromecoutant jeromecoutant deleted the jeromecoutant:PR_STDIO branch Jan 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment