STM32 UART init update #5570

jeromecoutant · 2017-11-23T14:09:28Z

Description

serial_init, serial_free and serial_baud functions moved from serial_device.c (specific to each STM32 family) to serial_api.c (common STM32 file)
default baudrate value was hardcoded to 9600
- Value is set now to MBED_CONF_PLATFORM_STDIO_BAUD_RATE for STDIO
- Value is set now to MBED_CONF_PLATFORM_DEFAULT_SERIAL_BAUD_RATE for other use
UART init will not be stopped before calling serial_baud function
for LPUART, init procedure can update the clock source depending on expected baudrate

This should close #5389 issue

Status

READY

Tests

OS2 and OS5 tests verified for all STM32 targets

- serial_init, serial_free and serial_baud function moved from serial_device.c (specific to each STM32 family) to serial_api.c (common STM32 file) - default baudrate value was hardcoded to 9600 - Value is set now to MBED_CONF_PLATFORM_STDIO_BAUD_RATE for STDIO - Value is set now to MBED_CONF_PLATFORM_DEFAULT_SERIAL_BAUD_RATE for other use - UART init will not be stopped before calling serial_baud function

bcostm · 2017-11-24T07:52:24Z

targets/TARGET_STM/TARGET_STM32F0/serial_device.c

-#if defined (TARGET_STM32F091RC)
-    #define UART_NUM (8)
+#if defined (TARGET_STM32F031K6)
+    #define UART_NUM (1


a parenthesis is missing ?

yes, I didn't see this build failure in the non reg tests... :-(

bcostm · 2017-11-24T07:54:48Z

targets/TARGET_STM/TARGET_STM32F4/serial_device.c

+    #define UART_NUM (6)
+#elif defined (TARGET_STM32F429xI) || defined (TARGET_STM32F439xI) || defined (TARGET_STM32F437xG) || defined (TARGET_STM32F469xI)
+    #define UART_NUM (8)
+#elif defined (TARGET_STM32F413xH)


maybe merge this #elif and the #else below ?

bcostm · 2017-11-24T07:56:21Z

targets/TARGET_STM/serial_api_hal.h


+// #include "cmsis.h"


remove this dead code ?

0xc0170 · 2017-11-24T08:38:41Z

@jeromecoutant Please look at travis failure, related to the changesets

jeromecoutant

Updates done (Travis will also be OK)
Thx for the code review

jeromecoutant · 2017-11-24T12:35:03Z

targets/TARGET_STM/TARGET_STM32F0/serial_device.c

-#if defined (TARGET_STM32F091RC)
-    #define UART_NUM (8)
+#if defined (TARGET_STM32F031K6)
+    #define UART_NUM (1


yes, I didn't see this build failure in the non reg tests... :-(

jeromecoutant · 2017-11-24T12:36:19Z

targets/TARGET_STM/TARGET_STM32F4/serial_device.c

+    #define UART_NUM (6)
+#elif defined (TARGET_STM32F429xI) || defined (TARGET_STM32F439xI) || defined (TARGET_STM32F437xG) || defined (TARGET_STM32F469xI)
+    #define UART_NUM (8)
+#elif defined (TARGET_STM32F413xH)


jeromecoutant · 2017-11-24T12:38:00Z

targets/TARGET_STM/serial_api_hal.h


+// #include "cmsis.h"


jeromecoutant · 2017-12-05T12:53:28Z

/morph test

0xc0170 · 2017-12-05T13:47:27Z

/morph build

mbed-ci · 2017-12-05T14:42:48Z

Build : SUCCESS

Build number : 655
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5570/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

mbed-ci · 2017-12-05T16:28:54Z

Test : FAILURE

Build number : 479
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5570/479

mbed-ci · 2017-12-05T19:47:18Z

Exporter Build : SUCCESS

Build number : 298
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5570/

kegilbert · 2017-12-06T17:35:37Z

We have seen related test failures intermittently, retesting to confirm.
/morph test

mbed-ci · 2017-12-06T18:40:24Z

Test : FAILURE

Build number : 484
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5570/484

0xc0170 · 2017-12-07T10:44:30Z

@jeromecoutant Getting a failure that we have seen earlier :/ Do you have the target to reproduce this failure?

/morph test

jeromecoutant · 2017-12-07T10:47:05Z

Failure is not related to the PR... it is a known issue: #5622

mbed-ci · 2017-12-07T12:31:20Z

Test : FAILURE

Build number : 488
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5570/488

jeromecoutant · 2017-12-13T10:10:08Z

Could this PR be merged ?
Thx

0xc0170 · 2017-12-13T10:12:50Z

/morph build

0xc0170 · 2017-12-14T10:43:52Z

/morph build

mbed-ci · 2017-12-14T11:18:55Z

Build : SUCCESS

Build number : 699
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5570/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

mbed-ci · 2017-12-14T12:44:52Z

Exporter Build : SUCCESS

Build number : 341
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5570/

mbed-ci · 2017-12-14T15:14:30Z

Test : FAILURE

Build number : 529
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5570/529

0xc0170 · 2017-12-14T15:44:05Z

The failure is known, being investigated, hopefully resolved soon

jeromecoutant · 2017-12-14T16:12:26Z

The failure is known,

So it can be merged ? :-)

0xc0170 · 2017-12-15T13:48:57Z

Green policy here 🍏 📗 needs to get green

0xc0170 · 2017-12-22T11:08:25Z

/morph test

mbed-ci · 2017-12-22T18:27:20Z

Test : FAILURE

Build number : 580
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5570/580

adbridge · 2017-12-29T11:27:48Z

/morph test

mbed-ci · 2017-12-29T13:37:59Z

Test : FAILURE

Build number : 603
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5570/603

0xc0170 · 2018-01-03T09:35:44Z

Needs to be rebuild I believe

/morph build

mbed-ci · 2018-01-03T10:08:21Z

Build : SUCCESS

Build number : 783
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5570/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

mbed-ci · 2018-01-03T10:51:02Z

Exporter Build : SUCCESS

Build number : 437
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5570/

mbed-ci · 2018-01-03T11:24:02Z

Test : SUCCESS

Build number : 618
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5570/618

0xc0170 · 2018-01-03T11:39:39Z

🍏 Green !

jeromecoutant added 2 commits November 23, 2017 14:47

STM32 LPUART : update clock source depending on expected baudrate

07e71d6

0xc0170 added the needs: review label Nov 23, 2017

bcostm reviewed Nov 24, 2017

View reviewed changes

0xc0170 added needs: work and removed needs: review labels Nov 24, 2017

STM32 uart: update after code review

1cf47f6

jeromecoutant commented Nov 24, 2017

View reviewed changes

0xc0170 added needs: review and removed needs: work labels Nov 24, 2017

bcostm approved these changes Nov 24, 2017

View reviewed changes

theotherjimmy requested a review from 0xc0170 November 27, 2017 16:21

0xc0170 approved these changes Dec 5, 2017

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Dec 5, 2017

jeromecoutant mentioned this pull request Dec 19, 2017

[NUCLEO-L476] 921600 baud does not work #5730

Closed

jeromecoutant mentioned this pull request Jan 3, 2018

Add memory barriers to STM32F7xx Ethernet #5720

Merged

0xc0170 added ready for merge and removed needs: CI labels Jan 3, 2018

theotherjimmy added the release-version: 5.7.3 label Jan 4, 2018

theotherjimmy merged commit 62a7ecd into ARMmbed:master Jan 4, 2018

theotherjimmy removed the ready for merge label Jan 4, 2018

jeromecoutant deleted the PR_STDIO branch January 4, 2018 15:51

STM32 UART init update #5570

STM32 UART init update #5570

Uh oh!

Conversation

jeromecoutant commented Nov 23, 2017

Description

Status

Tests

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Nov 24, 2017

Uh oh!

jeromecoutant left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jeromecoutant commented Dec 5, 2017

Uh oh!

0xc0170 commented Dec 5, 2017

Uh oh!

mbed-ci commented Dec 5, 2017

Triggering tests

Uh oh!

mbed-ci commented Dec 5, 2017

Uh oh!

mbed-ci commented Dec 5, 2017

Uh oh!

kegilbert commented Dec 6, 2017

Uh oh!

mbed-ci commented Dec 6, 2017

Uh oh!

0xc0170 commented Dec 7, 2017

Uh oh!

jeromecoutant commented Dec 7, 2017

Uh oh!

mbed-ci commented Dec 7, 2017

Uh oh!

jeromecoutant commented Dec 13, 2017

Uh oh!

0xc0170 commented Dec 13, 2017

Uh oh!

0xc0170 commented Dec 14, 2017

Uh oh!

mbed-ci commented Dec 14, 2017

Triggering tests

Uh oh!

mbed-ci commented Dec 14, 2017

Uh oh!

mbed-ci commented Dec 14, 2017

Uh oh!

0xc0170 commented Dec 14, 2017

Uh oh!

jeromecoutant commented Dec 14, 2017

Uh oh!

0xc0170 commented Dec 15, 2017

Uh oh!

0xc0170 commented Dec 22, 2017

Uh oh!

mbed-ci commented Dec 22, 2017

Uh oh!

adbridge commented Dec 29, 2017

Uh oh!

mbed-ci commented Dec 29, 2017

jeromecoutant left a comment •

edited

Loading

0xc0170 commented Jan 3, 2018 •

edited

Loading