New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow use of external memory as heap with TOOLCHAIN_GCC_ARM #5994

Merged
merged 1 commit into from Feb 2, 2018

Conversation

Projects
None yet
4 participants
@bmcdonnell-ionx
Contributor

bmcdonnell-ionx commented Feb 1, 2018

This PR addresses #5638. It allows the user to optionally (with the right additional software) use external memory for all dynamic memory with TOOLCHAIN_GCC_ARM, by allowing the user to override the _sbrk() function defined in platform/mbed_retarget.cpp.

For example, when using the Embedded Artists' LPC4088 QuickStart Board with EALib's SDRAM module (cpp, h) and the Mbed online compiler (and Keil uVision offline IDE, I presume), dynamic memory uses the off-chip on-board 32 MB SDRAM. I assume there are other boards that can support this behavior too, but this is the one I know of for sure. This PR makes this behavior the same on TOOLCHAIN_GCC_ARM.

@mbed-ci

This comment has been minimized.

mbed-ci commented Feb 1, 2018

User not whitelisted, CI not run.

@cmonr

cmonr approved these changes Feb 1, 2018

@cmonr cmonr added the needs: CI label Feb 1, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Feb 1, 2018

/morph build

2 similar comments
@cmonr

This comment has been minimized.

Contributor

cmonr commented Feb 1, 2018

/morph build

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Feb 1, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Feb 1, 2018

Build : SUCCESS

Build number : 1045
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5994/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit b8d2180 into ARMmbed:master Feb 2, 2018

19 checks passed

ARM mbed CI Verification build successful.
Details
AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details
@mbed-ci

This comment has been minimized.

@bmcdonnell-ionx bmcdonnell-ionx deleted the bmcdonnell-ionx:gcc-arm-extram branch Aug 2, 2018

@bmcdonnell-ionx

This comment has been minimized.

Contributor

bmcdonnell-ionx commented Aug 2, 2018

I just edited a typo in the OP here, and for some reason the CI did whatever it just did above.

:shrug:

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 2, 2018

@bmcdonnell-ionx Yeah, it's a known ghost in the machine that happens every once in a while, but considering how fast it fails and that it doesn't impact anything else in CI, it's a low priority fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment