Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Greentea netsocket more tests #6665
8 times, most recently
Apr 23, 2018
4 times, most recently
Apr 30, 2018
Add error handling.
There are multiple cases where you call socket functions without testing the return code.
get_interface()->gethostbyname(...); sock->open(...); sock->connect(...); sock->close();
Every socket call should be tested and compared against acceptable return values. Not only those that transfer the data, but also ones than translate names or create connection.
@cmonr My changes are not fixes, refactoring of existing code, breaking change to existing code, new features and do not consider new targets. I decided to add a new category to evoke this discussion. I would say there is need to have its own category for test cases. Unless new test case is to be treated like a new feature.
Build number : 2153
Build number : 1782