New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support RTOS-less secure image build with Cortex-M23/M33 #6747

Merged
merged 2 commits into from Apr 30, 2018

Conversation

Projects
None yet
6 participants
@ccli8
Contributor

ccli8 commented Apr 26, 2018

Description

By following the instructions of Reducing memory usage by tuning RTOS configuration, I build RTOS-less secure image for on-going, Cortex-M23 based target NUMAKER_PFM_M2351, and meet compile error with mbed-os/rtos/TARGET_CORTEX/mbed_rtx_conf.h unavailable in RTOS-less build. My .mbedignore has the following content:

mbed-os/rtos/*
mbed-os/features/cellular/
mbed-os/features/FEATURE_CLIENT/*
mbed-os/features/FEATURE_COMMON_PAL/*
mbed-os/features/FEATURE_UVISOR/*
mbed-os/features/frameworks/*
mbed-os/features/net/*
mbed-os/features/netsocket/*
mbed-os/features/nvstore/*
mbed-os/features/storage/*
mbed-os/events/*
mbed-os/features/lorawan/*

This PR tries to fix the error. The support for RTOS-less secure image build would be helpful to reduce memory footprint.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@deepikabhavnani

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented Apr 26, 2018

@ccli8 - We try to minimize changes in CMSIS files. It would be good to move defines into "cmsis/RTE_Components.h" (as that is Mbed OS specific) from mbed_rtx_conf.h.

CC @bulislaw

@ccli8

This comment has been minimized.

Contributor

ccli8 commented Apr 26, 2018

@deepikabhavnani Please check the commit
02730f0 for the modification.

@0xc0170 0xc0170 requested a review from deepikabhavnani Apr 26, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 26, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 26, 2018

Build : SUCCESS

Build number : 1858
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6747/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added needs: CI and removed needs: review labels Apr 27, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 27, 2018

@deepikabhavnani Can you review the update if now the location for those definitions is good?

@0xc0170 0xc0170 added needs: review and removed needs: CI labels Apr 27, 2018

@cmonr cmonr merged commit 0196ba7 into ARMmbed:master Apr 30, 2018

12 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 8894 cycles (-1310 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10112B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Apr 30, 2018

@ccli8 ccli8 deleted the OpenNuvoton:nuvoton_build_no_rtos_secure branch May 2, 2018

@deepikabhavnani deepikabhavnani referenced this pull request May 2, 2018

Merged

Update cmsis/rtx to version 5.3 #6273

1 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment