New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoRaWAN: Fixed region 2(AU915) to compile #6829

Closed
wants to merge 1 commit into
base: mbed-os-5.8
from

Conversation

Projects
None yet
6 participants
@AnttiKauppila
Contributor

AnttiKauppila commented May 7, 2018

ARM internal ref IOTCELL-948

Description

There was a typo in the code making it fail to compile

Pull request type

[x ] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
LoRaWAN: Fixed region 2(AU915) to compile
ARM internal ref IOTCELL-948
@AnttiKauppila

This comment has been minimized.

Contributor

AnttiKauppila commented May 7, 2018

This should go into next patch release 5.8.x

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 7, 2018

How come this was not catch in any of our CI?

cc @OPpuolitaival

@kivaisan

This comment has been minimized.

Contributor

kivaisan commented May 8, 2018

@kjbracey-arm please review

@0xc0170 0xc0170 added the do not merge label May 9, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 9, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented May 9, 2018

Build : SUCCESS

Build number : 1961
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6829/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@adbridge

This comment has been minimized.

Contributor

adbridge commented May 18, 2018

Manually cherry picked to 5.8.5

@adbridge adbridge closed this May 18, 2018

@adbridge adbridge removed the do not merge label May 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment