New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lora: fix AU915 build #6839

Merged
merged 1 commit into from May 14, 2018

Conversation

Projects
None yet
4 participants
@kivaisan
Contributor

kivaisan commented May 8, 2018

Description

There was a typo in the code making it fail to compile.

This PR should go to master. mbed-os 5.8.x branch is handled with a different PR (#6829) as code is moved to another place.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
Lora: fix AU915 build
There was a typo in the code making it fail to compile.
@cmonr

cmonr approved these changes May 8, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 8, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented May 8, 2018

Build : SUCCESS

Build number : 1944
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6839/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 8, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 9, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 11, 2018

/morph export-build

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 11, 2018

/morph test

@mbed-ci

This comment has been minimized.

@kivaisan

This comment has been minimized.

Contributor

kivaisan commented May 11, 2018

@cmonr this test error is not related to this PR?
[Error] main.cpp@17,0: #35: #error directive: [NOT_SUPPORTED] Tickless mode not supported for this target.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 14, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 14, 2018

Failure looks like in the testing tools (CI issue), will report this (update: reported as an issue, will be checked)

/morph test

@mbed-ci

This comment has been minimized.

@kivaisan

This comment has been minimized.

Contributor

kivaisan commented May 14, 2018

@cmonr This PR should not have 5.8.5 tag as target of this PR is 5.9.
This will be fixed to 5.8.x branch with own PR.

@cmonr cmonr merged commit 9fd04c4 into ARMmbed:master May 14, 2018

13 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 845 warnings (+0 warnings)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9643 cycles (+84 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment