New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename text region in ARM linker file for a few NXP CPUs #7242

Merged
merged 1 commit into from Jun 19, 2018

Conversation

Projects
None yet
5 participants
@davidsaada
Contributor

davidsaada commented Jun 18, 2018

Description

In most of the linker files for the ARM toolchain, the text region has a uniform name LR_IROM1. However, a few Freescale/NXP boards had the LR_m_text name instead. Beside this being not uniform, it doesn't allow us to determine the text region size at run time (which is required in a few future tests). In addition, the LR_IROM1 name is referred to in a few Handbook documents (like Bootstrap or Flash) and the LR_m_text name deviates from this documentation.
This change currently has no effect on anything other than the linker files themselves (These names aren't mentioned in the code).

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@cmonr cmonr requested a review from mmahadevan108 Jun 18, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 19, 2018

which is required in a few future tests

@davidsaada Thanks for fixing it. If this is going to be unified, we should document it and have this tested.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 19, 2018

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jun 19, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 19, 2018

Build : SUCCESS

Build number : 2382
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7242/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 19, 2018

/morph export-build

@davidsaada

This comment has been minimized.

Contributor

davidsaada commented Jun 19, 2018

Thanks for fixing it. If this is going to be unified, we should document it and have this tested.

Right. Will have separate PRs for it. Need to think of the test - It's not really a test, as the acceptance here is a successful build.

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 31df3d2 into ARMmbed:master Jun 19, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 925 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9022 cycles (-1108 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the needs: CI label Jun 19, 2018

@davidsaada davidsaada deleted the davidsaada:david_uniform_text_region branch Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment