New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: Add CellularDevice::init_module API to be called at startup #7667

Merged
merged 2 commits into from Aug 17, 2018

Conversation

Projects
None yet
6 participants
@AriParkkila
Contributor

AriParkkila commented Aug 1, 2018

Description

Added a new API CellularDevice::init_module to initialize cellular module. This function need to be called right after cellular module is ready to make any module specific initialization.

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[X] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-wan Aug 1, 2018

@AriParkkila

This comment has been minimized.

Contributor

AriParkkila commented Aug 1, 2018

@jarvte please review

@jarvte

jarvte approved these changes Aug 1, 2018

@0xc0170 0xc0170 changed the title from Cellular: Added CellularDevice::init_module API to be called at startup to Cellular: Add CellularDevice::init_module API to be called at startup Aug 1, 2018

@0xc0170

Please split functional changes from style changes ( 2 separate commits)

@AriParkkila AriParkkila force-pushed the AriParkkila:cellular-detect branch from f7558d7 to c6ab45b Aug 1, 2018

@AriParkkila

This comment has been minimized.

Contributor

AriParkkila commented Aug 1, 2018

Split functional changes from style changes in separate commits.

@jarvte please re-review

@jarvte

jarvte approved these changes Aug 1, 2018

@AriParkkila

This comment has been minimized.

Contributor

AriParkkila commented Aug 2, 2018

@0xc0170 please rereview

@AriParkkila

This comment has been minimized.

Contributor

AriParkkila commented Aug 13, 2018

@0xc0170 is there something still to do?

Changes addressed.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 14, 2018

@AriParkkila Nope! Thanks for the split.

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 14, 2018

Build : SUCCESS

Build number : 2793
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7667/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@AriParkkila

This comment has been minimized.

Contributor

AriParkkila commented Aug 15, 2018

@cmonr ci-morph-test is failing with "mbedgt: no platform/target matching tests were found!". That's unlikely due to this change?

@adbridge

This comment has been minimized.

Contributor

adbridge commented Aug 15, 2018

Looks like this has failed due to some networking issues in CI. Suggest we re-run this once the CI is less heavily loaded.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 16, 2018

/morph test

@mbed-ci

This comment has been minimized.

@cmonr

cmonr approved these changes Aug 17, 2018

@cmonr cmonr merged commit 871ee09 into ARMmbed:master Aug 17, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.12%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 583 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9198 cycles (-407 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the needs: CI label Aug 17, 2018

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7667 from AriParkkila/cellular-detect
Cellular: Add CellularDevice::init_module API to be called at startup

@AriParkkila AriParkkila deleted the AriParkkila:cellular-detect branch Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment