Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESP8266: OOB handling done based on arrival of SIGIOs #9503

Merged
merged 1 commit into from
Feb 20, 2019
Merged

ESP8266: OOB handling done based on arrival of SIGIOs #9503

merged 1 commit into from
Feb 20, 2019

Conversation

VeijoPesonen
Copy link
Contributor

@VeijoPesonen VeijoPesonen commented Jan 25, 2019 •
edited
Loading

Description

Instead of checking OOBs in certain interval uses UART activity as trigger. Throttles checks by setting a small arbitrary delay when raising an event.

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@SeppoTakalo
@kjbracey-arm
@michalpasztamobica

@VeijoPesonen
Copy link
Contributor Author

@0xc0170 depends from PR #9473

@ciarmcom
Copy link
Member

@VeijoPesonen, thank you for your changes.
@SeppoTakalo @kjbracey-arm @michalpasztamobica @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

michalpasztamobica
michalpasztamobica approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@michalpasztamobica michalpasztamobica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the "arbitrary small delay" could be just turned into a #define ESP_EVENT_PROCESSING_DELAY, but it would be nitpicking to stop the review for this tiny detail :-)

@VeijoPesonen VeijoPesonen mentioned this pull request Jan 29, 2019
Merged
@SeppoTakalo
Copy link
Contributor

Is there a dependency with #9503

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 13, 2019 •
edited
Loading

Is there a dependency with #9503

Was it #9515 ? or rather #9473

@VeijoPesonen What is the status for this PR ? It needs rebase now

@VeijoPesonen
Copy link
Contributor Author

@0xc0170 yes, #9473 is the one. And that one depends from ARMmbed/mbed-os-benchmarks#24 ...

@cmonr
Copy link
Contributor

cmonr commented Feb 13, 2019

ARMmbed/mbed-os-benchmarks#24 was just merged. It should now be in use within CI.

But looks like this needs to be rebased first :/

@VeijoPesonen
Copy link
Contributor Author

VeijoPesonen commented Feb 18, 2019 •
edited
Loading

@cmonr, @0xc0170 rebased.

@cmonr
Copy link
Contributor

cmonr commented Feb 19, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 19, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit ad2cb91 into ARMmbed:master Feb 20, 2019
@VeijoPesonen VeijoPesonen deleted the feature-esp8266_oob_handling_by_sigio branch February 20, 2019 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@michalpasztamobica michalpasztamobica michalpasztamobica approved these changes

@kjbracey kjbracey Awaiting requested review from kjbracey

Assignees
No one assigned
Labels
release-version: 5.12.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@VeijoPesonen @ciarmcom @SeppoTakalo @0xc0170 @cmonr @mbed-ci @michalpasztamobica