Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second barrier for core_util_atomic_flag_clear #9528

Merged
merged 1 commit into from Jan 30, 2019

Conversation

Projects
None yet
4 participants
@kjbracey-arm
Copy link
Contributor

commented Jan 29, 2019

Description

As barriers were added in #9247, review comments pointed out that atomic stores needed a second barrier, and they got one. But atomic_flag_clear was missed.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Second barrier for core_util_atomic_flag_clear
As barriers were added in #9247, review comments pointed out that atomic
stores needed a second barrier, and they got one. But atomic_flag_clear
was missed.

@cmonr cmonr added the needs: CI label Jan 29, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Jan 29, 2019

CI started

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Jan 29, 2019

@kjbracey-arm 5.12 instead of 5.11?

@mbed-ci

This comment has been minimized.

Copy link

commented Jan 30, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@kjbracey-arm

This comment has been minimized.

Copy link
Contributor Author

commented Jan 30, 2019

This is a fix for #9247, which is for 5.12

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jan 30, 2019

@0xc0170 0xc0170 merged commit c7998aa into ARMmbed:master Jan 30, 2019

24 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9215 cycles (-518 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.