Skip to content

Conversation

jeromecoutant
Copy link
Collaborator

Description

This fixes #8626

There is no restriction to enable SERIAL_FC at FAMILY_STM32 level,
and not for all targets 1 by 1.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team January 30, 2019 14:01
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this styling change be in separate commit please?

  • device_has styling update
  • serial_fc addition

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this styling change be in separate commit please?

done

@cmonr
Copy link
Contributor

cmonr commented Feb 2, 2019

CI started

@cmonr cmonr dismissed 0xc0170’s stale review February 2, 2019 03:28

Please re-review

@mbed-ci
Copy link

mbed-ci commented Feb 2, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 7e9181c into ARMmbed:master Feb 4, 2019
@jeromecoutant jeromecoutant deleted the PR_FC branch February 4, 2019 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update device peripherals for STM32 series
5 participants