Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32: Enable SERIAL_FC for all #9553

Merged
merged 3 commits into from Feb 4, 2019

Conversation

Projects
None yet
5 participants
@jeromecoutant
Copy link
Contributor

jeromecoutant commented Jan 30, 2019

Description

This fixes #8626

There is no restriction to enable SERIAL_FC at FAMILY_STM32 level,
and not for all targets 1 by 1.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Jan 30, 2019

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers Jan 30, 2019

@@ -7541,7 +7583,10 @@
"macro_name": "CLOCK_SOURCE"
}
},
"device_has_add": ["SERIAL_ASYNCH", "SERIAL_FC", "FLASH"],
"device_has_add": [

This comment has been minimized.

@0xc0170

0xc0170 Jan 30, 2019

Member

Can this styling change be in separate commit please?

  • device_has styling update
  • serial_fc addition

This comment has been minimized.

@jeromecoutant

jeromecoutant Feb 1, 2019

Author Contributor

Can this styling change be in separate commit please?

done

@0xc0170 0xc0170 added needs: work and removed needs: review labels Jan 30, 2019

@jeromecoutant jeromecoutant force-pushed the jeromecoutant:PR_FC branch to 715d16c Feb 1, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 2, 2019

CI started

@cmonr cmonr added needs: CI and removed needs: work labels Feb 2, 2019

@cmonr

cmonr approved these changes Feb 2, 2019

Please re-review

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 2, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170

0xc0170 approved these changes Feb 4, 2019

@0xc0170 0xc0170 merged commit 7e9181c into ARMmbed:master Feb 4, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10219 cycles (-304 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Feb 4, 2019

@jeromecoutant jeromecoutant deleted the jeromecoutant:PR_FC branch Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.