Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset internal vref buffer after an ADC conversion #9560

Merged
merged 2 commits into from Feb 1, 2019

Conversation

Projects
None yet
6 participants
@RobVlaar
Copy link

RobVlaar commented Jan 30, 2019

Description

Resolves: #9504

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@jeromecoutant

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers Jan 30, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Jan 30, 2019

@RobVlaar, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@cmonr cmonr requested a review from ARMmbed/team-st-mcd Jan 30, 2019

@cmonr
Copy link
Contributor

cmonr left a comment

Please fix indentation

@cmonr cmonr added needs: work and removed needs: review labels Jan 30, 2019

Rob Vlaar
@jeromecoutant
Copy link
Contributor

jeromecoutant left a comment

I think I will propose the same kind of patch for all STM32 families!
Thx

@cmonr

cmonr approved these changes Jan 31, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Jan 31, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Jan 31, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Jan 31, 2019

@0xc0170 0xc0170 merged commit 363f35f into ARMmbed:master Feb 1, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9096 cycles (-811 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Feb 1, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Feb 1, 2019

0xc0170 added release-version: 5.11.4 and removed release-version: 5.11.0-rc1 labels just now

released in the past , fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.