Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cortex-m33 armlink error #9625

Merged
merged 1 commit into from Feb 7, 2019

Conversation

Projects
None yet
5 participants
@mikisch81
Copy link
Contributor

mikisch81 commented Feb 6, 2019

Description

When building Cortex-m33 on ARMC6 a linkage error happen due to the fact that armlink uses the --cpu=cortex-m33.no_dsp.no_fp flags (no floating point) but armclang uses only -mcpu=cortex-m33+nodsp (with floating point).

PR #9480 probably accidently removed the -mfpu=none flag from the compilation command, so this PR restores it.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/mbed-os-tools @deepikabhavnani

Fix cortex-m33-S armlink error
Add "-mfpu=none" compilation flag
@mikisch81

This comment has been minimized.

Copy link
Contributor Author

mikisch81 commented Feb 6, 2019

@kjbracey-arm

This comment has been minimized.

Copy link
Contributor

kjbracey-arm commented Feb 6, 2019

#9480 was trying to transfer that to a +nofp on the CPU selection, and #9606 removed that because it didn't work, without putting the -mfpu=none back.

Compiler behaviour seems rather inconsistent here...

@mikisch81

This comment has been minimized.

Copy link
Contributor Author

mikisch81 commented Feb 6, 2019

@mikisch81

This comment has been minimized.

Copy link
Contributor Author

mikisch81 commented Feb 6, 2019

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

NirSonnenschein commented Feb 6, 2019

started CI

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 6, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@mikisch81

This comment has been minimized.

Copy link
Contributor Author

mikisch81 commented Feb 7, 2019

@NirSonnenschein CI passed, is it mergeable?

@0xc0170

0xc0170 approved these changes Feb 7, 2019

@0xc0170 0xc0170 merged commit 09db995 into ARMmbed:master Feb 7, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9092 cycles (-664 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.