Skip to content

/mbed-os

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues found in LPC55S69 integration #9957

Merged
merged 2 commits into from Mar 6, 2019

Conversation

Reviewers

@cmonr cmonr

@mmahadevan108 mmahadevan108

@orenc17 orenc17

@ChiefBureaucraticOfficer ChiefBureaucraticOfficer

Assignees
No one assigned
Labels
PM_ACCEPTED release-version: 5.12.0-rc2
Projects
None yet
Milestone
No milestone
7 participants
@mikisch81 @cmonr @mbed-ci @mmahadevan108 @orenc17 @ChiefBureaucraticOfficer @0xc0170
@mikisch81
Copy link
Contributor

commented Mar 6, 2019

Description

Fix issues found in LPC55S69 integration

  • Disable SPM-IPC tests which fail due to issues in TF-M.
  • Increase allowed ROT service count from 30 to 32.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@mikisch81 mikisch81 referenced this pull request Mar 6, 2019

Merged

Add support for LPC55S59 #9910

@mikisch81

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Mar 6, 2019

@orenc17
@mikisch81

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Mar 6, 2019 •
edited

@ARMmbed/mbed-os-maintainers @maclobdell
This PR is needed for #9910 LPC55S69 PSA target

@0xc0170 0xc0170 requested a review from ChiefBureaucraticOfficer Mar 6, 2019

@0xc0170 0xc0170 added release-version: 5.12.0-rc2 needs: review labels Mar 6, 2019

@0xc0170 0xc0170 requested a review from orenc17 Mar 6, 2019

@ChiefBureaucraticOfficer

ChiefBureaucraticOfficer approved these changes Mar 6, 2019
View changes

Copy link

left a comment

Meets post freeze criteria, needed for PSA support. Approved.

@ChiefBureaucraticOfficer ChiefBureaucraticOfficer added the PM_ACCEPTED label Mar 6, 2019

@0xc0170 0xc0170 requested a review from mmahadevan108 Mar 6, 2019

@mmahadevan108

mmahadevan108 approved these changes Mar 6, 2019
View changes

Copy link
Contributor

left a comment

Thank you
@orenc17

orenc17 approved these changes Mar 6, 2019
View changes

@mikisch81

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Mar 6, 2019

@ARMmbed/mbed-os-maintainers can we run CI?

@cmonr cmonr added needs: CI and removed needs: review labels Mar 6, 2019

@cmonr

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Mar 6, 2019

CI started
@mbed-ci

This comment has been minimized.

Sign in to view
Copy link

commented Mar 6, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts
@cmonr

cmonr approved these changes Mar 6, 2019
View changes

TESTS/psa/spm_client/COMPONENT_NSPE/main.cpp
Case("Testing client close on NULL handle", client_close_null_handle),
Case("Testing DROP_CONNECTION State", drop_connection),
Case("Testing client psa_framework_version() API", verify_psa_framework_version),
Case("Testing client psa_version() API on existing SID", psa_version_existing),
Case("Testing client psa_version() API on non-existing SID", psa_version_non_existing),
Case("Testing client psa_version() API to a service that is not NSPE callable", psa_version_secure_access_only),
Case("Testing client multiple calls on different channels to the same SID", multi_thread_diff_handles),
#if defined TARGET_MBED_SPM // TF-M issue: https://developer.trustedfirmware.org/T244

This comment has been minimized.

Sign in to view
Copy link
@cmonr

cmonr Mar 6, 2019

Contributor

🎉

Thank you for the link reference!

@cmonr cmonr merged commit ec845a7 into ARMmbed:master Mar 6, 2019
28 checks passed

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+36 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9984 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the needs: CI label Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.