Skip to content

Fix issues found in LPC55S69 integration #9957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 6, 2019
Merged

Fix issues found in LPC55S69 integration #9957

merged 2 commits into from
Mar 6, 2019

Conversation

mikisch81
Copy link
Contributor

Description

Fix issues found in LPC55S69 integration

  • Disable SPM-IPC tests which fail due to issues in TF-M.
  • Increase allowed ROT service count from 30 to 32.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@mikisch81 mikisch81 mentioned this pull request Mar 6, 2019
Merged
@mikisch81
Copy link
Contributor Author

@orenc17

@mikisch81
Copy link
Contributor Author

mikisch81 commented Mar 6, 2019 •
edited
Loading

@ARMmbed/mbed-os-maintainers @maclobdell
This PR is needed for #9910 LPC55S69 PSA target

@0xc0170 0xc0170 requested a review from a user March 6, 2019 15:20
@0xc0170 0xc0170 requested a review from orenc17 March 6, 2019 15:21
ghost
ghost approved these changes Mar 6, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meets post freeze criteria, needed for PSA support. Approved.

@ghost ghost added the PM_ACCEPTED label Mar 6, 2019
@0xc0170 0xc0170 requested a review from mmahadevan108 March 6, 2019 15:32
mmahadevan108
mmahadevan108 approved these changes Mar 6, 2019
View reviewed changes
Copy link
Contributor

@mmahadevan108 mmahadevan108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@mikisch81
Copy link
Contributor Author

@ARMmbed/mbed-os-maintainers can we run CI?

@cmonr
Copy link
Contributor

cmonr commented Mar 6, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 6, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

cmonr
cmonr approved these changes Mar 6, 2019
View reviewed changes
TESTS/psa/spm_client/COMPONENT_NSPE/main.cpp
Case("Testing client close on NULL handle", client_close_null_handle),
Case("Testing DROP_CONNECTION State", drop_connection),
Case("Testing client psa_framework_version() API", verify_psa_framework_version),
Case("Testing client psa_version() API on existing SID", psa_version_existing),
Case("Testing client psa_version() API on non-existing SID", psa_version_non_existing),
Case("Testing client psa_version() API to a service that is not NSPE callable", psa_version_secure_access_only),
Case("Testing client multiple calls on different channels to the same SID", multi_thread_diff_handles),
#if defined TARGET_MBED_SPM // TF-M issue: https://developer.trustedfirmware.org/T244
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Thank you for the link reference!

@cmonr cmonr merged commit ec845a7 into ARMmbed:master Mar 6, 2019
@cmonr cmonr removed the needs: CI label Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@mmahadevan108 mmahadevan108 mmahadevan108 approved these changes

@orenc17 orenc17 orenc17 approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.0-rc2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mikisch81 @cmonr @mbed-ci @mmahadevan108 @orenc17 @0xc0170