Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for LPC55S59 #9910

Merged
merged 21 commits into from Mar 8, 2019

Conversation

@mmahadevan108
Copy link
Contributor

commented Mar 2, 2019

Description

Cortex-M33 based platform. I will submit my test results.

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@mmahadevan108

This comment has been minimized.

Copy link
Contributor Author

commented Mar 2, 2019

@mmahadevan108

This comment has been minimized.

Copy link
Contributor Author

commented Mar 2, 2019

cc @AndreyButokNXP @nxp49431

@mmahadevan108

This comment has been minimized.

Copy link
Contributor Author

commented Mar 2, 2019

@mmahadevan108

This comment has been minimized.

Copy link
Contributor Author

commented Mar 2, 2019

The mbed-os-tests-mbed_platform-wait_ns test is failing.


[1551529466.18][CONN][RXD] >>> Running case #1: 'Test: wait_ns - compare with us_timer 1s'...
[1551529466.24][CONN][INF] found KV pair in stream: {{__testcase_start;Test: wait_ns - compare with us_timer 1s}}, queued...
mbedgt: :75::FAIL: Expected 1.200000 Was 0.602970
[1551529466.87][CONN][RXD] :75::FAIL: Expected 1.200000 Was 0.602970


I see the below comment in the wait_ns code inside mbed_wait_api_no_rtos.c file


// TODO - check M33


Can someone from ARM team take a look at the test failure and see if the mbed code needs to be updated?

@mmahadevan108

This comment has been minimized.

Copy link
Contributor Author

commented Mar 2, 2019

The mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack test fails only under GCC_ARM. I had spoken with @deepikabhavnani about updating the test case to increase the check range.

@mmahadevan108

This comment has been minimized.

Copy link
Contributor Author

commented Mar 2, 2019

I am working with @orenc17 @mikisch81 @maclobdell on the below failures:
mbed-os-features-storage-tests-blockdevice-general_block_device
mbed-os-features-storage-tests-kvstore-direct_access_devicekey_test
mbed-os-tests-mbed-crypto-sanity
mbed-os-tests-mbed_hal-spm
mbed-os-tests-psa-attestation
mbed-os-tests-psa-crypto_access_control
mbed-os-tests-psa-entropy_inject
mbed-os-tests-psa-its_ps

@mikisch81

This comment has been minimized.

Copy link
Contributor

commented Mar 2, 2019

The mbed-os-tests-mbed_platform-wait_ns test is failing.

[1551529466.18][CONN][RXD] >>> Running case #1: 'Test: wait_ns - compare with us_timer 1s'...
[1551529466.24][CONN][INF] found KV pair in stream: {{__testcase_start;Test: wait_ns - compare with us_timer 1s}}, queued...
mbedgt: :75::FAIL: Expected 1.200000 Was 0.602970
[1551529466.87][CONN][RXD] :75::FAIL: Expected 1.200000 Was 0.602970

I see the below comment in the wait_ns code inside mbed_wait_api_no_rtos.c file

// TODO - check M33

Can someone from ARM team take a look at the test failure and see if the mbed code needs to be updated?

@kjbracey-arm @deepikabhavnani

@deepikabhavnani

This comment has been minimized.

Copy link
Contributor

commented Mar 2, 2019

The mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack test fails only under GCC_ARM.

Please update the test in this PR itself to check the stack pointer in entire stack range (0x400) instead 128 bytes

https://github.com/ARMmbed/mbed-os/blob/master/TESTS/mbedmicro-rtos-mbed/heap_and_stack/main.cpp#L207

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 2, 2019

@mikisch81

This comment has been minimized.

Copy link
Contributor

commented Mar 3, 2019

@mmahadevan108
In order to simplify the building process, mainly for tests, we opened a PR to find the secure image during post-build of the non-secure target: #9894.

The usage of this can be seen here.

@mikisch81

This comment has been minimized.

Copy link
Contributor

commented Mar 3, 2019

@mmahadevan108 #9823 was merged so you can rebase.
You still need #9915, #9916 and #9894, hopefully they will be merged soon.

@mikisch81

This comment has been minimized.

Copy link
Contributor

commented Mar 3, 2019

@ARMmbed/mbed-os-maintainers this needs a 5.12.0-rc1 label

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

commented Mar 4, 2019

@mmahadevan108 , please take a look at the travis failures : https://travis-ci.org/ARMmbed/mbed-os/jobs/500777066

@mikisch81

This comment has been minimized.

Copy link
Contributor

commented Mar 4, 2019

@mmahadevan108 Also you need to rebase as a lot of fixes are already upstream.

mmahadevan108 and others added some commits Feb 11, 2019

MCUXpresso: In pin_function() use mask macro instead of a hard-coded …
…value

The mask size can vary based on the platform

Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
MCUXpresso: Update SPI driver
Move the clock setup and peripheral reset to the init function

Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
Add support for LPC55S69
Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
MCUXpresso: Update the sleep implementation for LPC55S69 differences
Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
LPC55S69: Remove FPU_PRESENT and DSP_PRESENT defines
These are defined by mbed during compile

Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
LPC55S69: Add a ctimer for usticker to be used in the secure domain
CTIMER 0 is used for the secure domain and CTIMER 1 is used for
the non-secure domain

Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
MCUXpresso: Update Analogin support
Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
LPC55S69: Fix the I2C SDK driver
Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
LPC55S69: Update the KVStore config files
Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
LPC55S69: Add post processing script
Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
Updated LOOP_SCALER value for Cortex-M33
Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
Increase the stack pointer check range
Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
Reduce the number of flash operation related veneer table entries
Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
Updated the binaries
Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
@mikisch81

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2019

A rebase is needed as there is conflict in the tdbstore mbed_lib.json

@mmahadevan108 mmahadevan108 force-pushed the NXPmicro:Add_LPC55S69_TFM_mbed_master branch to 862961c Mar 8, 2019

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2019

ci started

@adbridge adbridge added needs: CI and removed needs: work labels Mar 8, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 8, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Mar 8, 2019

@0xc0170

0xc0170 approved these changes Mar 8, 2019

Copy link
Member

left a comment

Can be fixed in new PR (next patch release) - new files should contain SPDX identifier - I've noticed some hal files missing in this PR.

@0xc0170 0xc0170 merged commit 0e532ba into ARMmbed:master Mar 8, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10350 cycles (+1198 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Mar 8, 2019

@mmahadevan108

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.