Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate #include #2326

Merged
merged 1 commit into from Jan 24, 2019

Conversation

Projects
None yet
4 participants
@masap
Copy link
Contributor

commented Jan 3, 2019

Signed-off-by: Masashi Honma masashi.honma@gmail.com

Status

READY

Requires Backporting

NO

Migrations

NO

Additional comments

None

Todos

None

Steps to test or reproduce

make check passed

@masap

This comment has been minimized.

Copy link
Contributor Author

commented Jan 3, 2019

This PR replaces PR #2318.

@masap masap referenced this pull request Jan 3, 2019

Closed

Remove duplicate #include #2318

Remove duplicate #include
Signed-off-by: Masashi Honma <masashi.honma@gmail.com>
@RonEld

RonEld approved these changes Jan 3, 2019

Copy link
Contributor

left a comment

Thank you for addressing our comments from the previous PR.
LGTM

@RonEld

This comment has been minimized.

Copy link
Contributor

commented Jan 3, 2019

Note: This will require backporting to branches mbedtls-2.7 and mbedtls-2.16

@sbutcher-arm sbutcher-arm referenced this pull request Jan 9, 2019

Merged

Backport 2.7: Remove duplicate #include #2341

0 of 4 tasks complete
@sbutcher-arm

This comment has been minimized.

Copy link
Collaborator

commented Jan 9, 2019

Backported this PR to mbedtls-2.7 as PR #2341.

The PR doesn't need backporting to mbedtls-2.16 as this PR is based on Mbed TLS 2.16.0 and can be merged into both development and mbedtls-2.16.

@RonEld

This comment has been minimized.

Copy link
Contributor

commented Jan 10, 2019

The backport to mbedtls-2.7 has been fully approved, so removing the "needs backports" label

@sbutcher-arm sbutcher-arm merged commit fbda612 into ARMmbed:development Jan 24, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@masap masap deleted the masap:trivial_fix branch Mar 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.