Skip to content

Conversation

@masap
Copy link
Contributor

@masap masap commented Jan 3, 2019

Signed-off-by: Masashi Honma masashi.honma@gmail.com

Status

READY

Requires Backporting

NO

Migrations

NO

Additional comments

None

Todos

None

Steps to test or reproduce

make check passed

@masap
Copy link
Contributor Author

masap commented Jan 3, 2019

This PR replaces PR #2318.

@masap masap mentioned this pull request Jan 3, 2019
Signed-off-by: Masashi Honma <masashi.honma@gmail.com>
@RonEld RonEld requested a review from AndrzejKurek January 3, 2019 08:07
@RonEld RonEld added bug CLA valid component-crypto Crypto primitives and low-level interfaces labels Jan 3, 2019
Copy link
Contributor

@RonEld RonEld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing our comments from the previous PR.
LGTM

@RonEld RonEld added the needs-backports Backports are missing or are pending review and approval. label Jan 3, 2019
@RonEld
Copy link
Contributor

RonEld commented Jan 3, 2019

Note: This will require backporting to branches mbedtls-2.7 and mbedtls-2.16

@simonbutcher
Copy link
Contributor

Backported this PR to mbedtls-2.7 as PR #2341.

The PR doesn't need backporting to mbedtls-2.16 as this PR is based on Mbed TLS 2.16.0 and can be merged into both development and mbedtls-2.16.

@RonEld
Copy link
Contributor

RonEld commented Jan 10, 2019

The backport to mbedtls-2.7 has been fully approved, so removing the "needs backports" label

@RonEld RonEld removed the needs-backports Backports are missing or are pending review and approval. label Jan 10, 2019
@simonbutcher simonbutcher added the approved Design and code approved - may be waiting for CI or backports label Jan 10, 2019
@simonbutcher simonbutcher merged commit fbda612 into Mbed-TLS:development Jan 24, 2019
@masap masap deleted the trivial_fix branch March 4, 2019 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Design and code approved - may be waiting for CI or backports bug component-crypto Crypto primitives and low-level interfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants