fix memory leak in mpi_miller_rabin() #2363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes memory leak in mpi_miller_rabin() that occurs when the function has failed to obtain a usable random 'A' 30 turns in a row. Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
RonEld
added
bug
CLA valid
needs-review
|
@jenswi-linaro Thank you for your contribution! Would you be willing to add an entry in the ChangeLog, crediting yourself \ Linaro for the contribution? |
|
Note: CLA is valid, as part of the Linaro project CLA |
RonEld
suggested changes
Jan 17, 2019
|
Note: Requires backporting to |
RonEld
added
the
needs-backports
|
Added a change log entry. Please let me know if this is what you had in mind. |
RonEld
reviewed
Jan 17, 2019
ChangeLog
Outdated
| previously lead to a stack overflow on constrained targets. | ||
| * Add `MBEDTLS_SELF_TEST` for the mbedtls_self_test functions | ||
| in the header files, which missed the precompilation check. #971 | ||
| * Fix memory leak in in mpi_miller_rabin() |
There was a problem hiding this comment.
Suggested change
| * Fix memory leak in in mpi_miller_rabin() | |
| * Fix memory leak in in mpi_miller_rabin(). Contributed by Jens Wiklander in #2363. |
Unless you prefer the credit to be given to Linaro.
There was a problem hiding this comment.
Thanks for the suggestion. I added both. :-)
|
Thank you for adding the ChangeLog entry. I added a suggestion for a change, as we credit the contributors in the ChangeLog. |
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
jenswi-linaro
force-pushed
the
fix_memleak
branch
from
58aff29 to
035eaea
Compare
RonEld
approved these changes
Jan 18, 2019
AndrzejKurek
approved these changes
Jan 21, 2019
dgreen-arm
approved these changes
Jan 22, 2019
RonEld
removed
the
needs-review
This was referenced Jan 31, 2019
RonEld
removed
the
needs-backports
|
Backports have been fully approved, so removed the "needs backports" label |
Patater
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes memory leak in mpi_miller_rabin() that occurs when the function has
failed to obtain a usable random 'A' 30 turns in a row.
Signed-off-by: Jens Wiklander jens.wiklander@linaro.org
Notes:
or for companies or those that do not wish to create an mbed account, a slightly different agreement can be found here
Description
A few sentences describing the overall goals of the pull request's commits.
Status
READY/IN DEVELOPMENT/HOLD
Requires Backporting
When there is a bug fix, it should be backported to all maintained and supported branches.
Changes do not have to be backported if:
Yes | NO
Which branch?
Migrations
If there is any API change, what's the incentive and logic for it.
YES | NO
Additional comments
Any additional information that could be of interest
Todos
Steps to test or reproduce
Outline the steps to test or reproduce the PR here.