fix: fix up ui-components linting and update some misaligned rules

Author: RyanTheAllmighty

packages/eslint-config-atlauncher/configs/electron.js

@@ -1,5 +1,5 @@
 module.exports = {
     rules: {
-        'import/core-modules': ['electron'],
+        'import/core-modules': ['error', 'electron'],
     }
 };

packages/eslint-config-atlauncher/configs/react.js

@@ -0,0 +1,14 @@
+const base = require('./index');
+
+const rules = base.extends.concat([
+    // configs
+    './configs/electron'
+].map(require.resolve));
+
+module.exports = {
+    plugins: base.plugins,
+    extends: rules,
+    env:  base.env,
+    parser:  base.parser,
+    parserOptions:  base.parserOptions
+};

packages/eslint-config-atlauncher/electron.js

@@ -1,8 +1,3 @@
-const configs = [
-    './configs/electron',
-    './configs/react'
-].map(require.resolve);
-
 const rules = [
     // eslint rules
     './rules/possible-errors',
@@ -13,7 +8,6 @@ const rules = [
     './rules/ecmascript-6',
 
     // eslint plugins
-    './rules/plugin-filenames',
     './rules/plugin-import',
     './rules/plugin-jsx-a11y',
     './rules/plugin-promise',
@@ -30,7 +24,6 @@ module.exports = {
         'filenames'
     ],
     extends: rules,
-    configs,
     env: {
         node: true,
         es6: true,

packages/eslint-config-atlauncher/index.js

@@ -26,7 +26,6 @@
   "devDependencies": {
     "babel-eslint": "^7.2.1",
     "eslint": "^3.19.0",
-    "eslint-plugin-filenames": "^1.1.0",
     "eslint-plugin-import": "^2.2.0",
     "eslint-plugin-jsx-a11y": "^4.0.0",
     "eslint-plugin-no-empty-blocks": "0.0.2",
@@ -36,8 +35,10 @@
   "peerDependencies": {
     "babel-eslint": "^7.2.1",
     "eslint": "^3.19.0",
-    "eslint-plugin-jsx-a11y": "^4.0.0",
     "eslint-plugin-import": "^2.2.0",
+    "eslint-plugin-jsx-a11y": "^4.0.0",
+    "eslint-plugin-no-empty-blocks": "0.0.2",
+    "eslint-plugin-promise": "^3.5.0",
     "eslint-plugin-react": "^6.10.3"
   },
   "engines": {

packages/eslint-config-atlauncher/package.json

@@ -46,21 +46,12 @@ module.exports = {
 
         // don't use the `.js` extension in the import path for local files
         'import/extensions': ['error', 'always', {
-            'js': 'never'
-        }],
-
-        // make sure imports are ordered
-        'import/order': ['error', {
-            'newlines-between': 'always',
-            'groups': [
-                ['external', 'builtin'],
-                ['index', 'sibling', 'parent', 'internal']
-            ]
+            js: 'never'
         }],
 
         // make sure there is one new line after imports
         'import/newline-after-import': ['error', {
-            'count': 1
+            count: 1
         }]
     }
 };

packages/eslint-config-atlauncher/rules/plugin-filenames.js

@@ -68,8 +68,8 @@ module.exports = {
         // requires all components to be written as ES6 classes and not via `React.createClass`
         'react/prefer-es6-class': 'error',
 
-        // ensures stateless components aren't doing more than they should
-        'react/prefer-stateless-function': 'error',
+        // ensures stateless components are used where possible over `React.Component` but allow `React.PureComponent`
+        'react/prefer-stateless-function': ['warn', {ignorePureComponents: true}],
 
         // ensures PropType's are written and contain all properties are added into it
         'react/prop-types': 'error',

packages/eslint-config-atlauncher/rules/plugin-import.js

@@ -16,8 +16,16 @@ module.exports = {
             properties: 'always'
         }],
 
-        // all comments should start with a lowercase letter
-        'capitalized-comments': ['error', 'never'],
+        // all comments should start with a lowercase letter unless in a block comment
+        'capitalized-comments': ['error', 'never', {
+            line: {
+                ignoreInlineComments: true
+            },
+            block: {
+                ignoreInlineComments: true,
+                ignorePattern: '.'
+            }
+        }],
 
         // don't allow dangling commas
         'comma-dangle': ['error', 'never'],
@@ -179,7 +187,7 @@ module.exports = {
             allowTemplateLiterals: true
         }],
 
-        // warn when not using jsdoc
+        // warn when not using jsdoc unless function name matches one in the ignore list
         'require-jsdoc': ['warn', {
             require: {
                 FunctionDeclaration: true,

packages/eslint-config-atlauncher/rules/plugin-react.js

@@ -1,3 +1,3 @@
 {
     "extends": ["@atlauncher/eslint-config-atlauncher"]
-}
+}