Skip to content
This repository was archived by the owner on May 16, 2020. It is now read-only.

Commit 591ddb5

Browse files
fix: update to node >= 6 and fix broken linting
1 parent c70d781 commit 591ddb5

File tree

9 files changed

+3588
-899
lines changed

9 files changed

+3588
-899
lines changed

package-lock.json

Lines changed: 1644 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/babel-preset-atlauncher/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,6 @@
2424
"babel-preset-stage-0": "^6.24.1"
2525
},
2626
"engines": {
27-
"node": ">= 4"
27+
"node": ">= 6"
2828
}
2929
}

packages/eslint-config-atlauncher/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,13 +41,13 @@
4141
"eslint": "^3.19.0",
4242
"eslint-plugin-eslint-comments": "^1.0.1",
4343
"eslint-plugin-filenames": "^1.2.0",
44-
"eslint-plugin-import": "^2.2.0",
45-
"eslint-plugin-jsx-a11y": "^4.0.0",
44+
"eslint-plugin-import": "^2.3.0",
45+
"eslint-plugin-jsx-a11y": "^5.0.3",
4646
"eslint-plugin-no-empty-blocks": "^0.0.2",
4747
"eslint-plugin-promise": "^3.5.0",
48-
"eslint-plugin-react": "^6.10.3"
48+
"eslint-plugin-react": "^7.0.1"
4949
},
5050
"engines": {
51-
"node": ">= 4"
51+
"node": ">= 6"
5252
}
5353
}

packages/eslint-config-atlauncher/rules/plugin-jsx-a11y.js

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ module.exports = {
3131
'jsx-a11y/iframe-has-title': 'error',
3232

3333
// require all image tags to have an `alt` property
34-
'jsx-a11y/img-has-alt': 'error',
34+
'jsx-a11y/alt-text': 'error',
3535

3636
// don't allow the workds `image`, `photo` or `picture` in image `alt` property
3737
'jsx-a11y/img-redundant-alt': 'error',
@@ -67,6 +67,12 @@ module.exports = {
6767
'jsx-a11y/scope': 'error',
6868

6969
// don't allow positive values for `tabIndex`
70-
'jsx-a11y/tabindex-no-positive': 'error'
70+
'jsx-a11y/tabindex-no-positive': 'error',
71+
72+
// warn when media doesn't have caption`
73+
'jsx-a11y/media-has-caption': 'warn',
74+
75+
// don't allow tabIndex on non interactive elements
76+
'jsx-a11y/no-noninteractive-tabindex': 'error'
7177
}
7278
};

packages/eslint-config-atlauncher/rules/plugin-react.js

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
module.exports = {
22
settings: {
33
react: {
4-
version: '15.5.3'
4+
version: '15.5.4'
55
}
66
},
77
rules: {
@@ -157,7 +157,11 @@ module.exports = {
157157
'react/jsx-pascal-case': 'error',
158158

159159
// require a space before self closing tags such as `<A prop={prop} />` rather than `<A prop={prop}/>`
160-
'react/jsx-space-before-closing': 'error',
160+
'react/jsx-tag-spacing': ['error', {
161+
closingSlash: 'never',
162+
beforeSelfClosing: 'always',
163+
afterOpening: 'never'
164+
}],
161165

162166
// ensures components that import React don't show it as being unused
163167
'react/jsx-uses-react': 'error',
@@ -166,6 +170,9 @@ module.exports = {
166170
'react/jsx-uses-vars': 'error',
167171

168172
// ensures multiline JSX is wrapped within parenthesis
169-
'react/jsx-wrap-multilines': 'error'
173+
'react/jsx-wrap-multilines': 'error',
174+
175+
// prevent usage of setState in componentWillUpdate
176+
'react/no-will-update-set-state': 'error'
170177
}
171178
};

packages/eslint-plugin-atlauncher/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,6 @@
2525
"eslint": "^3.19.0"
2626
},
2727
"engines": {
28-
"node": ">= 4"
28+
"node": ">= 6"
2929
}
3030
}

packages/ui-components/components/Button/Button.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
import React, { PropTypes } from 'react';
1+
import React from 'react';
2+
import PropTypes from 'proptypes';
23

34
import './Button.less';
45

0 commit comments

Comments
 (0)