feat: add in rules for import plugin and start of configs

Author: RyanTheAllmighty

packages/eslint-config-atlauncher/configs/electron.js

@@ -0,0 +1,5 @@
+module.exports = {
+    rules: {
+        'import/core-modules': ['electron'],
+    }
+};

packages/eslint-config-atlauncher/configs/react.js

@@ -0,0 +1,5 @@
+/* eslint-disable import/no-commonjs */
+
+module.exports = {
+    rules: {}
+};

packages/eslint-config-atlauncher/index.js

@@ -1,8 +1,15 @@
 /* eslint-disable filenames/no-index */
+/* eslint-disable import/no-commonjs */
+
+const configs = [
+    './configs/electron',
+    './configs/react'
+].map(require.resolve);
 
 const rules = [
     './rules/base',
-    './rules/filenames'
+    './rules/plugin-filenames',
+    './rules/plugin-import'
 ].map(require.resolve);
 
 module.exports = {
@@ -16,12 +23,12 @@ module.exports = {
     ],
     extends: [
         'eslint:recommended',
-        'plugin:import/recommended',
         'plugin:jsx-a11y/recommended',
         'plugin:react/recommended',
         'plugin:promise/recommended',
         ...rules
     ],
+    configs,
     env: {
         node: true,
         es6: true,
@@ -36,6 +43,5 @@ module.exports = {
             experimentalObjectRestSpread: true,
             jsx: true
         }
-    },
-    rules: {}
+    }
 };

packages/eslint-config-atlauncher/rules/base.js

@@ -1,3 +1,5 @@
+/* eslint-disable import/no-commonjs */
+
 module.exports = {
     rules: {
         "no-empty": "off", // this is covered by the 'no-empty-blocks' plugin

packages/eslint-config-atlauncher/rules/filenames.js renamed to packages/eslint-config-atlauncher/rules/plugin-filenames.js

@@ -1,3 +1,5 @@
+/* eslint-disable import/no-commonjs */
+
 module.exports = {
     rules: {
         "filenames/no-index": "error"

packages/eslint-config-atlauncher/rules/plugin-import.js

@@ -0,0 +1,38 @@
+/* eslint-disable import/no-commonjs */
+
+module.exports = {
+    rules: {
+        // static analysis
+        'import/no-unresolved': 'error',
+        'import/named': 'error',
+        'import/default': 'error',
+        'import/namespace': 'error',
+        'import/no-absolute-path': 'error',
+
+        // helpful warnings
+        'import/export': 'error',
+        'import/no-named-as-default': 'warn',
+        'import/no-named-as-default-member': 'warn',
+        'import/no-deprecated': 'warn',
+        'import/no-extraneous-dependencies': 'error',
+        'import/no-mutable-exports': 'error',
+
+        // module systems
+        'import/unambiguous': 'warn',
+        'import/no-commonjs': 'error',
+        'import/no-amd': 'error',
+
+        // style guide
+        'import/first': ['error', {'absolute-first': true}],
+        'import/no-duplicates': 'error',
+        'import/extensions': ['error', 'always', {'js': 'never'}],
+        'import/order': ['error', {
+            'newlines-between': 'always',
+            'groups': [
+                ['external', 'builtin'],
+                ['index', 'sibling', 'parent', 'internal']
+            ]
+        }],
+        'import/newline-after-import': ["error", {'count': 1}]
+    }
+};