Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pin command #105

Merged
merged 6 commits into from
Mar 27, 2024
Merged

Add pin command #105

merged 6 commits into from
Mar 27, 2024

Conversation

cheahTJ
Copy link

@cheahTJ cheahTJ commented Mar 27, 2024

No description provided.

cheahTJ and others added 6 commits March 17, 2024 23:27
@cheahTJ
Create PinCommand feature to allow pinning of students
a7b904d
@cheahTJ
Merge master into pin-contacts
7a43db3
@cheahTJ
Create PinCommand feature
e12a712
@cheahTJ
Create PinCommand and PinCommandParser test classes
af32687
@cheahTJ
Merge branch 'master' into pin-contacts
48c5b03 
* master:
  Update DeleteCommand.java
  resolve errors
  Update DeleteCommandParser.java
  documentationupdate
  Update DeleteCommandParser.java
  Update DeleteCommandParser.java
  Resolve review
  update testcases
  checkstyle
  Update DeleteCommand.java
  Update DeleteCommand.java
  update checkstyle
  Update DeleteCommandParser.java
  Update DeleteCommand.java
  modify-delete-command
@hjuntan
Merge pull request #99 from cheahTJ/pin-contacts
497e594 
Create PinCommand feature
@codecov Codecov
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 77.08333% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 76.29%. Comparing base (02d35e7) to head (497e594).
Report is 17 commits behind head on master.

Files Patch % Lines
...va/seedu/address/logic/commands/DeleteCommand.java 63.15% 10 Missing and 4 partials ⚠️
...seedu/address/logic/parser/GroupCommandParser.java 25.00% 1 Missing and 2 partials ⚠️
...eedu/address/logic/parser/DeleteCommandParser.java 81.81% 1 Missing and 1 partial ⚠️
.../seedu/address/logic/parser/AddressBookParser.java 0.00% 1 Missing ⚠️
...a/seedu/address/logic/parser/PinCommandParser.java 87.50% 0 Missing and 1 partial ⚠️
...a/seedu/address/model/person/UniquePersonList.java 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #105      +/-   ##
============================================
- Coverage     76.44%   76.29%   -0.16%     
- Complexity      521      545      +24     
============================================
  Files            82       84       +2     
  Lines          1690     1772      +82     
  Branches        169      187      +18     
============================================
+ Hits           1292     1352      +60     
- Misses          347      360      +13     
- Partials         51       60       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cheahTJ cheahTJ self-assigned this Mar 27, 2024
@hjuntan
Copy link

hjuntan commented Mar 27, 2024

Issue mentioned in pr #99: Documentation. Rmb to add documentation later on

@hjuntan hjuntan merged commit 344512f into master Mar 27, 2024
8 checks passed
@hjuntan hjuntan added this to the v1.3 milestone Mar 27, 2024
@hjuntan hjuntan linked an issue Mar 27, 2024 that may be closed by this pull request
Add pin contacts #43
Closed
@hjuntan
Copy link

hjuntan commented Mar 27, 2024

Closes #43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cheahTJ cheahTJ

Labels
None yet
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

Add pin contacts
2 participants
@cheahTJ @hjuntan