Create PinCommand feature #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delete command had no functionality to delete via a group. Added this functionality so that it is easier to delete large groups of contacts at once if required.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## add-pin-command #99 +/- ##
=====================================================
- Coverage 76.44% 76.29% -0.16%
- Complexity 521 545 +24
=====================================================
Files 82 84 +2
Lines 1690 1772 +82
Branches 169 187 +18
=====================================================
+ Hits 1292 1352 +60
- Misses 347 360 +13
- Partials 51 60 +9 ☔ View full report in Codecov by Sentry. |
Ragnapop
reviewed
Mar 27, 2024
| public class PinCommand extends Command { | ||
| public static final String COMMAND_WORD = "pin"; | ||
| public static final String MESSAGE_USAGE = COMMAND_WORD + ": Pin a student to the top of the address book. " | ||
| + "Parameters: NusId (8 digits long, starting with an 'E'). \n" |
There was a problem hiding this comment.
just realised nusid is 7 digits long, not 8
Comment on lines
+37
to
+39
| List<Person> lastShownList = model.getFilteredPersonList(); | ||
| Person personToPin = lastShownList.stream().filter(person -> person.getNusId().equals(nusId)) | ||
| .findFirst().orElse(null); |
Comment on lines
+35
to
+37
| private static boolean arePrefixesPresent(ArgumentMultimap argumentMultimap, Prefix... prefixes) { | ||
| return Stream.of(prefixes).allMatch(prefix -> argumentMultimap.getValue(prefix).isPresent()); | ||
| } |
There was a problem hiding this comment.
This method could be useful for every future class, consider re-adapting this into ArgumentMultimap class as a public method?
…ete-command Modify delete command
…15-2/delete_feature Able to delete in group for delete feature
* master: Update DeleteCommand.java resolve errors Update DeleteCommandParser.java documentationupdate Update DeleteCommandParser.java Update DeleteCommandParser.java Resolve review update testcases checkstyle Update DeleteCommand.java Update DeleteCommand.java update checkstyle Update DeleteCommandParser.java Update DeleteCommand.java modify-delete-command
|
Require documentation of pin command: Can be added in another pr |
hjuntan
merged commit 497e594
into
AY2324S2-CS2103T-T15-2:add-pin-command
5 checks passed
Merged
Comment on lines
+75
to
+77
| for (int i = 0; i < lastShownList.size(); i++) { | ||
| if (lastShownList.get(i).getGroups().equals(deletedGroup) ) { | ||
| peopleToDelete.add(lastShownList.get(i)); |
There was a problem hiding this comment.
possible case of deep nesting, perhaps extracting a new method might look better>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to #43, will work on the test cases in the upcoming commit