Export Imath from a build tree. #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make each file path of ImathConfig.cmake.in and ImathConfigVersion.cmake exact. Signed-off-by: Yuya Asano <64895419+sukeya@users.noreply.github.com>
|
Thanks for spotting this issue. It looks good to me, we just need someone to check that it works with our internal builds. |
|
@meshula, I've built OpenEXR against this change, both as an external installation and an internal build, and both succeed, as does the CI. What other checks were you imagining to validate the "internal builds"? |
|
Nothing special, I just wanted to give space for studios such as yours to make sure it doesn't impact your internal build. |
|
Apologies for the long delay |
cary-ilm
pushed a commit
to cary-ilm/Imath
that referenced
this pull request
Jan 23, 2024
…n#347) make each file path of ImathConfig.cmake.in and ImathConfigVersion.cmake exact. Signed-off-by: Yuya Asano <64895419+sukeya@users.noreply.github.com>
cary-ilm
pushed a commit
to cary-ilm/Imath
that referenced
this pull request
Jan 24, 2024
…n#347) make each file path of ImathConfig.cmake.in and ImathConfigVersion.cmake exact. Signed-off-by: Yuya Asano <64895419+sukeya@users.noreply.github.com>
cary-ilm
pushed a commit
that referenced
this pull request
Jan 24, 2024
make each file path of ImathConfig.cmake.in and ImathConfigVersion.cmake exact. Signed-off-by: Yuya Asano <64895419+sukeya@users.noreply.github.com>
netbsd-srcmastr
referenced
this pull request
in NetBSD/pkgsrc
Jan 28, 2024
## Version 3.1.10 (January 26, 2024)
Patch release with various build/bug fixes.
Build fixes:
- Fix a problem where downstream projects using Imath would build
python bindings even if they weren't requested.
- Fix for missing `std::bit_cast`
- Fix missing/necessary use of IMATH_HOSTDEVICE
- IMATH_INSTALL_PKG_CONFIG is now on by default, even on Windows
- Fix calling default constructor by uniform init in TypeTraits
- Fix redundant PYIMATH_EXPORTS causing compile issues on Windows Clang
- Update to SO versioning policy:
This change adopts a policy of appending the ``MAJOR.MINOR.PATCH``
software release name to the ``SONAME`` to form the real name of the
shared library.
See [website/install.rst](website/install.rst) and [PR
#339](AcademySoftwareFoundation/openexr#339)
for more details.
Bug fixes:
- Fix half to float giving wrong results on older x86_64 CPUs on Windows
Other changes:
- succ()/pred() now use std::nextafter().
- Expand epsilon bounds for m44x pyImath test.
- Rename "docs" to "website".
- Add missing copyright/license identifiers.
### Merged Pull Requests
* \[[#363](https://github.com/AcademySoftwareFoundation/Imath/pull/363)\]
Update install instructions to reflect new SO versioning policy
* \[[#362](https://github.com/AcademySoftwareFoundation/Imath/pull/362)\]
Require sphinx 5.0
* \[[#361](https://github.com/AcademySoftwareFoundation/Imath/pull/361)\]
src/python/config/ModuleDefine.cmake: do not install a cmake file exporting targets for dependent projects
* \[[#358](https://github.com/AcademySoftwareFoundation/Imath/pull/358)\]
Fix half to float giving wrong results on older x86_64 CPUs on Windows
* \[[#353](https://github.com/AcademySoftwareFoundation/Imath/pull/353)\]
Changed implementation of succ and pred to use std::nextafter.
* \[[#350](https://github.com/AcademySoftwareFoundation/Imath/pull/350)\]
Fix check for the availability of std::bit_cast
* \[[#349](https://github.com/AcademySoftwareFoundation/Imath/pull/349)\]
IMATH_INSTALL_PKG_CONFIG is on by default, even on Windows
* \[[#347](https://github.com/AcademySoftwareFoundation/Imath/pull/347)\]
Export Imath from the build tree and so on.
* \[[#344](https://github.com/AcademySoftwareFoundation/Imath/pull/344)\]
rm unnecessary IMATH_HOSTDEVICE attributes.
* \[[#342](https://github.com/AcademySoftwareFoundation/Imath/pull/342)\]
Add missing copyright/license identifiers
* \[[#341](https://github.com/AcademySoftwareFoundation/Imath/pull/341)\]
Remove unnecessary files
* \[[#340](https://github.com/AcademySoftwareFoundation/Imath/pull/340)\]
Fix calling default constructor by uniform init.
* \[[#339](https://github.com/AcademySoftwareFoundation/Imath/pull/339)\]
Update and simply SO versioning policy
* \[[#338](https://github.com/AcademySoftwareFoundation/Imath/pull/338)\]
Rename "docs" to "website"
* \[[#333](https://github.com/AcademySoftwareFoundation/Imath/pull/333)\]
Expand epsilon bounds for m44x pyImath test
* \[[#331](https://github.com/AcademySoftwareFoundation/Imath/pull/331)\]
Fixed redundant PYIMATH_EXPORTS causing compile issues on Windows Clang
* \[[#326](https://github.com/AcademySoftwareFoundation/Imath/pull/326)\]
Use security@openexr.com for consistency
* \[[#320](https://github.com/AcademySoftwareFoundation/Imath/pull/320)\]
Add missing IMATH_HOSTDEVICE to Matrix33<T>::invert(bool)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I encountered an error saying that
Imathwasn't in any export set when adding Imath and Alembic byadd_subdirectory(), so I made a change exporting Imath from a build tree and making each file path ofImathConfig.cmake.inandImathConfigVersion.cmakeexact.However, this PR requires the following code
Imath/CMakeLists.txt
Line 58 in 4d4e01c
and I can't understand the reason. So, if anyone have a better way, please feel free to tell me.