Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage #1436

Conversation

JeanChristopheMorinPerso
Copy link
Member

This PR adds test coverage for the AnyVector and AnyDictionary python bindings and the opentimelineio.core._core_utils module.

It supersedes #1433.

I also change the builds a little bit so that the coverage is measured in debug mode to improve the accuracy of the C++ code coverage when running the python tests and I also added --rc lcov_branch_coverage=1 to the lcov commands.

Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1436 (811ee44) into main (170dae2) will decrease coverage by 7.54%.
The diff coverage is 94.50%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1436      +/-   ##
==========================================
- Coverage   86.38%   78.84%   -7.55%     
==========================================
  Files         201      203       +2     
  Lines       20860    22259    +1399     
  Branches     2298     4522    +2224     
==========================================
- Hits        18020    17549     -471     
- Misses       2244     2437     +193     
- Partials      596     2273    +1677     
Flag Coverage Δ
py-unittests 78.84% <94.50%> (-7.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ineio/opentimelineio-bindings/otio_anyDictionary.h 78.00% <0.00%> (-4.93%) ⬇️
...imelineio/opentimelineio-bindings/otio_anyVector.h 59.61% <0.00%> (+9.61%) ⬆️
...-opentimelineio/opentimelineio/core/_core_utils.py 84.12% <ø> (+2.14%) ⬆️
...ntimelineio/opentimelineio-bindings/otio_tests.cpp 28.72% <50.00%> (-41.70%) ⬇️
tests/test_core_utils.py 98.75% <98.75%> (ø)
tests/test_opentime.py 99.74% <100.00%> (+<0.01%) ⬆️
tests/test_serializable_collection.py 97.46% <100.00%> (+0.06%) ⬆️
...elineio/opentimelineio-bindings/otio_anyVector.cpp 30.76% <0.00%> (-69.24%) ⬇️
...entimelineio-bindings/otio_serializableObjects.cpp 24.72% <0.00%> (-66.85%) ⬇️
...timelineio/opentime-bindings/opentime_bindings.cpp 33.33% <0.00%> (-66.67%) ⬇️
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 170dae2...811ee44. Read the comment docs.

Copy link
Collaborator

@ssteinbach ssteinbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small stuff, looks pretty good. Thanks @JeanChristopheMorinPerso!

.github/workflows/python-package.yml Show resolved Hide resolved
Makefile Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@ssteinbach ssteinbach added this to the Public Beta 16 milestone Sep 30, 2022
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
@JeanChristopheMorinPerso JeanChristopheMorinPerso marked this pull request as ready for review October 4, 2022 19:20
@JeanChristopheMorinPerso JeanChristopheMorinPerso requested review from ssteinbach and meshula and removed request for meshula and ssteinbach October 4, 2022 19:21
@ssteinbach ssteinbach merged commit c11f5ba into AcademySoftwareFoundation:main Oct 4, 2022
@JeanChristopheMorinPerso JeanChristopheMorinPerso deleted the improve_test_coverage branch October 4, 2022 19:23
MichaelPlug pushed a commit to MichaelPlug/OpenTimelineIO that referenced this pull request Aug 5, 2023
* Increase test coverage
* Fix linting

Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
Signed-off-by: Michele Spina <michelespina96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants