-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cmake cleanup #837
Cmake cleanup #837
Conversation
…s to set warnings. Suppress pybind11 warning tsunami because it doesn't tell us anything useful.
Codecov Report
@@ Coverage Diff @@
## master #837 +/- ##
=======================================
Coverage 84.18% 84.18%
=======================================
Files 74 74
Lines 3061 3061
=======================================
Hits 2577 2577
Misses 484 484
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Related: #813 Before merging, I need to test pip's --target directive to make sure the target is properly transmitted to the cmake script. |
Maybe related: #838 ~ If there is a more general PyInstaller issue, we could reopen 838 after this PR is merged. |
Thanks! I confirm this will solve #813. I've tested the Thanks, hope this will land soon :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of really small questions around commenting and removing some debug statements
This commit allows a full cmake build.