Refactor setup.py to build and stage into temp area for setup.py to install from #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e wheel build directory
… into the wheel build directory" This reverts commit db96069.
…specified by setuptools and allow it to handle the final install dir. This allows setuptools to handle targeting the final install using products of the intermediate install.
… from somewhere else) and trued up setuptools and pip with the versions enforced in setup.py
…with 32/64-bit issues.
…behavior more explicit
ssteinbach
changed the title
Codecov Report
@@ Coverage Diff @@
## master #956 +/- ##
=======================================
Coverage 85.63% 85.63%
=======================================
Files 191 191
Lines 18160 18160
Branches 2061 2061
=======================================
Hits 15552 15552
Misses 2085 2085
Partials 523 523
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
reinecke
commented
Apr 28, 2021
meshula
approved these changes
Apr 28, 2021
ssteinbach
approved these changes
Apr 28, 2021
…ter clarify intent for our future selves
|
When some hacks are removed from a setup.py file, it makes me extremely happy 😁 Great work! |
ssteinbach
approved these changes
Apr 29, 2021
|
Let's land this one and move on! I'll do it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors
setup.pyto properly leverage the newly cleaned up cmake builds (reworked in #837).(Note: this replaces #955 that wouldn't reopen due to GitHub oddness)
Summarize your change.
Our
setup.pyhad been arranged to try and figure out the final install location for for the libraries and place products in there. The python packaging utilities actually want you to assemble your build into a temp location where it will then pick it up to either package or install to the proper place.This refactor now tells the cmake build to install into that temp location. Because of this, we have to manually maintain much less code that supports determining the user's desired end action with the assembled package (e.x. install, install using --user, bdist, bdist_wheel).
Other changes include:
_Ctxclass instance that was storing build config as a global - it made it hard to follow the flow of code and would likely be prone to bugs.-jxflag generation to be based on detected number of system CPUs (better compile speeds!)