ImfChromaticities.h/cpp: Typo and pass by ref change. #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix spelling typo in the comment block. Better to pass "chroma" arg in by ref. Signed-off-by: Arkell Rasiah <arasiah@pixsystem.com>
arkellr
force-pushed
the
bugfix/arkellr-imfchromaticities-typos
branch
from
b560885
to
0ac66c7
Compare
cary-ilm
approved these changes
Feb 4, 2020
|
Will switching to pass-by-ref change the ABI? If so this change would need to be released in OpenEXR-2.5.0, rather than OpenEXR-2.4.1? |
|
It certainly will change the ABI. |
|
Yes this PR does change the ABI for those calls. Will make a mental note to flag it in my PRs next time... so u can squirrel it to the appropriate release candidate version. |
cary-ilm
added
the
Needs Discussion
cary-ilm
added
Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix spelling typo in the comment block.
Better to pass "chroma" arg in by ref.