asserts: Add assert-string=. #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
|
But then, maybe add more equality operators, to mirror the toolset of CL in general? Not much left: |
aadcg
force-pushed
the
add-assert-string=
branch
from
93f8778 to
b3ddcc1
Compare
|
I don't see why not @aartaka. PR revised accordingly. |
aartaka
reviewed
Aug 22, 2022
Assertions for string=, string-equal, string/=, string-not-equal, char=, char-equal, char/=, char-not-equal, = /=.
aadcg
force-pushed
the
add-assert-string=
branch
from
b3ddcc1 to
12eb4f9
Compare
|
CC @bobbysmith007, @ryepup, how does that look to you? |
|
Its has been too long to have much insight, but it looks right to me. |
|
Care to merge then? :) |
|
Thanks! |
Closed
|
There is a mistake in this pull request: none of the new symbols are exported. |
|
I will open a new PR. My mistake, sorry. |
|
See #15. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.