fix: Activate when an assistive technology is actually running on Unix #628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I have tested this myself. The change is very small but very important for downstream projects such as Godot. I'll merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously initializing the Unix adapter when the accessibility was enabled on the system. It turns out that many distributions seem to start AT-SPI by default, thus we get initialized on many systems where no assistive technology is running.
The
ScreenReaderEnabledD-Bus property has to be explicitly set by an assistive technology when it starts. As such, it is a far better indication for us that we should send a tree. A faulty AT could forget to set this property and get no tree from AccessKit at all, but I think it is easier to fix a handful of ATs on Unix rather than dealing with annoyed users who would have to pay an unnecessary performance hit for something they don't use.