Let trayicon owning program handle coloring it with filters #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't forget to remove the now-unused image :) |
|
Oh yeah. Did that here ActivityWatch/media#2 . Will need that merged so I can update the submodule here. |
|
This pull request introduces 1 alert when merging d5102b0 into 91f250b - view on LGTM.com new alerts:
|
xylix
force-pushed
the
dev/trayicon-color-fix
branch
from
d5102b0
to
7f3647b
Compare
|
This pull request introduces 1 alert when merging 7f3647b into 91f250b - view on LGTM.com new alerts:
|
|
Sorry for the delay. Merged the other PR now. Did you test it by changing the system theme while running? |
ErikBjare
reviewed
Apr 5, 2020
|
I did test it by changing system theme while it was running, and it worked for me on macOS catalina. (the icon changed color as expected) |
xylix
force-pushed
the
dev/trayicon-color-fix
branch
from
7f3647b
to
5385d8b
Compare
|
Nice, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ActivityWatch/activitywatch#358
@ErikBjare I think this can be merged.