Feature request: test TCP connection speed and return the fastest IP #715

Zxilly · 2019-04-12T07:53:01Z

When upstream return a DNS resolved answer,could AdGuard try to connect all the ip and give the client the IP fastest?
This is because in China the “clean” always means slow.

ameshkov · 2019-04-12T07:57:34Z

You mean this?

Zxilly · 2019-04-12T09:59:17Z

You mean this?

This means the fastest result from DNS server.Sometimes,the DNS server will return serveral IP,if the AdGuard could try to connect these IP and give the fastest IP to client,the client could get the better experience

Zxilly · 2019-04-14T10:59:59Z

@ameshkov Any suggestion?

ameshkov · 2019-04-14T21:02:51Z

@Zxilly I got the idea, thank you!

Marked as a feature request, let's see how many people vote for it.

Meanwhile, do you have any examples of the software that actually does it?

Zxilly · 2019-04-15T05:03:47Z

@ameshkov
https://github.com/pymumu/smartdns
https://github.com/zwhFocus/Installtion/tree/master/DNS-choose/dnschooser
But both are not open-source and the document is in Chinese(Maybe because only China has such terrible network environment)

ameshkov · 2019-04-15T07:41:56Z

What I am interested in is how exactly do they check if IP is available.

Do they send ICMP (ping) the address, or do they actually try to connect to ports 80 or 443?

Zxilly · 2019-04-15T08:07:01Z

@ameshkov
According to the article of the second project,it choose to make TCP connect to 80 and 443 because ICMP sometimes is not not allowed by some server.
This means it can not make effort on those applications whick are not using standard http port,but it truly improve the experience of HTTP.

alexsannikov · 2019-04-22T17:53:26Z

Test depends on protocol (HTTP/HTTPS/TCP/UDP/etc.);
ICMP may be measured, not sure about others protocols;
Idea sounds good, looks like some simplified PfR (Performance Routing);
but:
Realization of the check may be difficult enough;
Fastest response doesn't guarantee fastest service (back-end may be overloaded, for example);
Anyway, it must be a user's choice to turn this feature on.

ameshkov · 2019-04-22T18:25:17Z

Well, let's see how many upvotes does this feature request collect.

It is doable, but it is not easy of course.

ghost · 2019-04-25T14:31:14Z

The Project "SmartDNS" 's document in English
https://github.com/pymumu/smartdns/blob/master/ReadMe_en.md

WhoJave · 2019-08-16T10:23:28Z

Sometimes, I use parallel queries, it return an IP address that have no access to it . Cause we use Chinese public DNS... Maybe you could according the GEOIP to judge which DNS Server we could use , Or give us a choice . thx

liang-hiwin · 2019-10-30T12:31:04Z

I also requested to increase the DNS resolution to return the fastest ip to the user, otherwise this will cause the page to open very slowly.

rufengsuixing · 2019-11-22T02:52:13Z

there are some downloads use muti cdn to speedup download,block slower ip may have bad influence,if you want to use,maybe you can set smartdns as the only upstream of AdGuardHome

QiuSimons · 2020-01-03T02:32:29Z

Well, let's see how many upvotes does this feature request collect.

It is doable, but it is not easy of course.

SmartDNS is finally open source, can you refer to its source code? I think this will be helpful for this project.

https://github.com/pymumu/smartdns

ameshkov · 2020-01-06T19:53:10Z

@QiuSimons thank you, we'll take a look!

lordraiden · 2020-03-24T22:43:16Z

Is smartdns functionality going to be release in 0.102?
https://github.com/pymumu/smartdns/blob/master/ReadMe_en.md

ameshkov · 2020-03-24T22:44:19Z

Yes

lordraiden · 2020-03-24T22:52:37Z

Yes

This is a huge improvement, thanks a lot.
Please try to expose as much configuration settings as possible if not all through the interface, if this is too much put it somewhere more hidden under advanced settings but still available in the UI.
https://github.com/pymumu/smartdns/blob/master/ReadMe_en.md#configuration-parameter
Probably some of them doesn't make sense or are available somewhere else.

Having as well advanced settings for the cache avaialable in the interface would be nice.
Similar to what you can see in the right side of this screenshot.
https://forum.netgate.com/assets/uploads/files/1567263869587-settings.png

* API: /dns_info, /dns_config: add "parallel_requests" instead of "all_servers" from /set_upstreams_config * API: /status: removed fields #715 Squashed commit of the following: commit 7dd913b Merge: 4370697 8170955 Author: Simon Zolin <s.zolin@adguard.com> Date: Wed Apr 22 19:09:36 2020 +0300 Merge remote-tracking branch 'origin/master' into 715-fastest-addr commit 4370697 Author: Simon Zolin <s.zolin@adguard.com> Date: Wed Apr 22 19:08:55 2020 +0300 minor commit 9e713df Merge: e3bf403 9b7c118 Author: Simon Zolin <s.zolin@adguard.com> Date: Tue Apr 21 16:02:03 2020 +0300 Merge remote-tracking branch 'origin/master' into 715-fastest-addr commit e3bf403 Author: Simon Zolin <s.zolin@adguard.com> Date: Tue Apr 21 15:40:49 2020 +0300 minor commit d6e6a82 Author: Simon Zolin <s.zolin@adguard.com> Date: Fri Apr 17 17:56:24 2020 +0300 * API changes . removed POST /set_upstreams_config . removed fields from GET /status: bootstrap_dns, upstream_dns, all_servers . added new fields to /dns_config and /dns_info commit 237a452 Author: Simon Zolin <s.zolin@adguard.com> Date: Fri Apr 17 16:43:13 2020 +0300 * API: /dns_info, /dns_config: add "parallel_requests" instead of "all_servers" from /set_upstreams_config commit 9976723 Author: Simon Zolin <s.zolin@adguard.com> Date: Mon Mar 23 10:28:25 2020 +0300 openapi commit 6f8ea16 Merge: 36e4d4e c8285c4 Author: Simon Zolin <s.zolin@adguard.com> Date: Fri Mar 20 19:18:48 2020 +0300 Merge remote-tracking branch 'origin/master' into 715-fastest-addr commit 36e4d4e Author: Simon Zolin <s.zolin@adguard.com> Date: Fri Mar 20 18:13:43 2020 +0300 + DNS: add fastest_addr setting

sassansh · 2020-05-15T16:56:32Z

Any benefit in using this outside of China?

ameshkov · 2020-05-15T17:00:55Z

@sassansh regardless of your location, it can improve connection quality and make it more reliable as it will make sure that the IP addresses are really reachable from your location. Just don't use it with too many resolvers, 2-3 max.

sassansh · 2020-05-15T17:09:56Z

@ameshkov cool! can it be used with just 1 resolver?

ameshkov · 2020-05-15T17:11:35Z

@sassansh sure, but in this case, it will simply filter out unreachable/slow IPs from domains with multiple IPs (different CDNs and such).

sassansh · 2020-05-15T17:13:14Z

@ameshkov so is it best to use 2-3 resolvers when using this feature?

sassansh · 2020-05-15T17:18:57Z

I set it up as such:

We'll see how it goes...

yegle · 2020-05-27T07:40:58Z

Scratching my head for a while before realizing the options "Fastest IP address" and "Parallel requests" are mutual exclusive :-(

Why not changing them to radio?

ameshkov · 2020-05-27T08:07:31Z

Yeah, we'll make it clear in the next update:)

ameshkov added the question label Apr 12, 2019

ameshkov added feature request and removed question labels Apr 14, 2019

ameshkov changed the title ~~Could AdGuard support TCP test?~~ Feature request: test TCP connection speed and return the fastest IP Apr 22, 2019

ameshkov added the P2: High label Oct 31, 2019

ameshkov added this to the v1.0 milestone Oct 31, 2019

ameshkov modified the milestones: v1.0, v0.103 Jan 6, 2020

ameshkov modified the milestones: v0.103, v0.102 Feb 17, 2020

ameshkov assigned szolin Feb 17, 2020

szolin assigned ArtemBaskal Apr 8, 2020

szolin closed this as completed Apr 23, 2020

yatounoneko mentioned this issue May 16, 2020

[Feature Request] Fastest IP address problem v0.102.0 #1679

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature request: test TCP connection speed and return the fastest IP #715

Feature request: test TCP connection speed and return the fastest IP #715

Zxilly commented Apr 12, 2019

ameshkov commented Apr 12, 2019

Zxilly commented Apr 12, 2019

Zxilly commented Apr 14, 2019

ameshkov commented Apr 14, 2019

Zxilly commented Apr 15, 2019

ameshkov commented Apr 15, 2019 •

edited

Loading

Zxilly commented Apr 15, 2019

alexsannikov commented Apr 22, 2019

ameshkov commented Apr 22, 2019

ghost commented Apr 25, 2019

WhoJave commented Aug 16, 2019

liang-hiwin commented Oct 30, 2019

rufengsuixing commented Nov 22, 2019

QiuSimons commented Jan 3, 2020

ameshkov commented Jan 6, 2020

lordraiden commented Mar 24, 2020 •

edited

Loading

ameshkov commented Mar 24, 2020

lordraiden commented Mar 24, 2020 •

edited

Loading

sassansh commented May 15, 2020

ameshkov commented May 15, 2020 •

edited

Loading

sassansh commented May 15, 2020

ameshkov commented May 15, 2020

sassansh commented May 15, 2020

sassansh commented May 15, 2020

yegle commented May 27, 2020

ameshkov commented May 27, 2020

Feature request: test TCP connection speed and return the fastest IP #715

Feature request: test TCP connection speed and return the fastest IP #715

Comments

Zxilly commented Apr 12, 2019

ameshkov commented Apr 12, 2019

Zxilly commented Apr 12, 2019

Zxilly commented Apr 14, 2019

ameshkov commented Apr 14, 2019

Zxilly commented Apr 15, 2019

ameshkov commented Apr 15, 2019 • edited Loading

Zxilly commented Apr 15, 2019

alexsannikov commented Apr 22, 2019

ameshkov commented Apr 22, 2019

ghost commented Apr 25, 2019

WhoJave commented Aug 16, 2019

liang-hiwin commented Oct 30, 2019

rufengsuixing commented Nov 22, 2019

QiuSimons commented Jan 3, 2020

ameshkov commented Jan 6, 2020

lordraiden commented Mar 24, 2020 • edited Loading

ameshkov commented Mar 24, 2020

lordraiden commented Mar 24, 2020 • edited Loading

sassansh commented May 15, 2020

ameshkov commented May 15, 2020 • edited Loading

sassansh commented May 15, 2020

ameshkov commented May 15, 2020

sassansh commented May 15, 2020

sassansh commented May 15, 2020

yegle commented May 27, 2020

ameshkov commented May 27, 2020

ameshkov commented Apr 15, 2019 •

edited

Loading

lordraiden commented Mar 24, 2020 •

edited

Loading

lordraiden commented Mar 24, 2020 •

edited

Loading

ameshkov commented May 15, 2020 •

edited

Loading