Skip to content

1.5.7

Latest

Choose a tag to compare

@Alban1911 Alban1911 released this 16 Nov 18:34

Rose v1.5.7

Highlights

  • Rose starts about 20 seconds sooner. The launcher's skin library check took 20 to 25 seconds even with nothing to download; it now takes about 2. It still checks every file, downloads what is missing or changed and removes what the library dropped. (#515 by @itsdaymi)
  • Rose connects to League as soon as the client starts. A client started after Rose could be noticed up to 20 seconds late, and everything Rose sets up for champion select waited on it. Rose now waits for the client with a Windows folder notification, which costs nothing while League is closed. (#514 by @itsdaymi)
  • Safer updates. An update is now unpacked and checked in a folder beside Rose, swapped in once Rose closes, and rolled back if the swap or the restart fails. Before, an update interrupted by a locked file or a power cut could leave Rose half old and half new. (#505 by @itsdaymi, from #501 by @archwwes)
  • Party Mode: nobody with a party's invite can pose as another member anymore. Each Rose installation joins with its own private key, and the party server won't let another installation take the place of a member who is connected. Every member needs Rose 1.5.7: older versions are asked to update to use Party Mode. (#506 by @itsdaymi, from #501 by @archwwes)
  • Party Mode works on networks that block some of the party server's addresses, such as Spanish internet providers during LaLiga matches. Rose tries each of the server's addresses in turn. When none works, the error says whether the server could not be found, could not be reached or was cut off, and suggests a VPN or Cloudflare WARP. (#557)
  • Rose never reads the memory of LeagueClient.exe or the game. When the client's lockfile is empty, Rose reads the connection details from LeagueClientUx.exe with a query-only access, and the diagnostics script no longer opens the client or the game to read their paths. (#559)

Fixes

  • Skins work when Rose runs as administrator through another Windows account than the one you are signed in with, or when "Run as administrator" is set on Rose's ltk_launcher.exe. Rose takes that setting off by itself, and Troubleshooting names either cause instead of suggesting missing files or an update. (#558)
  • Troubleshooting no longer ends up recommending the 2 s maximum Injection Threshold on every PC: the recommendation is measured correctly now. The default stays at 1 s. (#513 by @itsdaymi)
  • A changed Injection Threshold applies at once, without restarting Rose. (#540 by @Lng999)
  • After a dodge, or a champion select that ends without a game, the next champion select gets its skin again, and no LTK Manager session is left running in the lobby. (#547 by @Lng999)
  • A mod that LTK Manager finished adding after a dodge no longer stays turned on in your LTK Manager library. (#523 by @Lng999)
  • Picking or unpicking a custom mod in the last seconds of champion select no longer breaks that game's injection. (#546 by @Lng999)
  • Swiftplay: a skin name Rose does not know is no longer matched to another champion's skin (Dimension Breaker Jinx was taken for a Sion skin). A canceled search drops the mods prepared for it, and a late answer from the client no longer mixes up two champions' skins. (#536 by @Lng999, #509 by @archwwes)
  • An interrupted skin sync no longer deletes skins. Rose only removes files after a complete sync, and only the ones it downloaded itself and that are unchanged. The partial downloads a stopped sync leaves behind are cleaned up. (#504 by @itsdaymi, from #501 by @archwwes; #524 by @Lng999)
  • An old lockfile no longer keeps Rose trying to connect to a client that is gone. (#510 by @archwwes, from #508 by @itsdaymi)
  • Rose keeps your champion select through a single missed update from the client, instead of dropping the lock or the session. (#519, #520, #521 by @Lng999)
  • Custom skins are fixed for the current patch on the home screen too, not only in a lobby, so LTK Manager no longer turns one off in game for that. (#537 by @Lng999)
  • Quit and Restart in the tray menu work while Rose is still starting, and Rose's cleanup finishes after a quit from the tray. (#538, #539 by @Lng999)
  • The category mods you picked are selected again when Rose restarts. (#531 by @Lng999)
  • Deleting mods clears them from the selection, including several at once and a .modpkg mod still being added. A mod that could not be deleted is kept whole, and a mod LTK Manager rejected but Rose could not remove is shown as still in the library. (#541, #545 by @Lng999, #509 by @archwwes)
  • A damaged party key file no longer blocks Party Mode until you delete it by hand: Rose makes a new key.
  • Rose's plugins, the party bar included, find Rose again when it starts after the League client. (#533, #535 by @Lng999)
  • Your skin history is kept when its file cannot be read. (#525 by @Lng999)
  • Troubleshooting asks you to update LTK Manager when its patcher does not support the game's build yet, and keeps an LTK patcher refusal when you raise the threshold. (#543 by @Lng999)
  • The error dialogs shown when Rose cannot start say where the log file is, instead of "N/A". (by @spookier)

Under the hood

  • Logs are written from a background thread, so a slow disk no longer holds up the client bridge, and the last log lines are kept when Rose has to force its exit. (#499 by @Lostmore)
  • Rose's local bridge refuses requests that do not address it as localhost (DNS rebinding). (#526 by @Lng999)
  • Mod files with a malformed bin or WAD entry are refused instead of hanging or crashing the reader. (#542, #544 by @Lng999)
  • The custom skin selector no longer scans the page during games, and the plugins no longer leave listeners behind after each game. Their logs use the right levels, and a rejected skin selection logs the client's real answer. (#522, #527, #528, #529, #530, #532, #534 by @Lng999)

Thanks to @itsdaymi, @Lng999, @archwwes, @Lostmore and @spookier for the pull requests, and to everyone who reported issues with logs.