Fix ServiceMonitor for Clickhouse Metrics #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slach
requested changes
Nov 21, 2023
There was a problem hiding this comment.
Thanks for your contributing
Unfortunately it will not work.
please look and try to figure out
https://github.com/Altinity/clickhouse-operator/blob/0.23.0/dev/generate_helm_chart.sh
after that, please add patch to this script instead of generated templates
Slach
approved these changes
Nov 21, 2023
|
this is not generated file, thanks for contribution again |
Slach
added a commit
that referenced
this pull request
Dec 13, 2023
Signed-off-by: Slach <bloodjazman@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for taking the time to contribute to
clickhouse-operator!Please, read carefully instructions on how to make a Pull Request.
This will help a lot for maintainers to adopt your Pull Request.
Important items to consider before making a Pull Request
Please check items PR complies to:
next-releasebranch, not intomasterbranch1. More info--
1 If you feel your PR does not affect any Go-code or any testable functionality (for example, PR contains docs only or supplementary materials), PR can be made into
masterbranch, but it has to be confirmed by project's maintainer.After I upgraded to
v0.22.0I saw that my metrics where missing and then I found out that the ServiceMonitor was scraping the old port name, this PR fixes it. Thanks!