Commands #1363
Merged
Commands #1363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ify a pass and are separated when creating the potentially visible set and binned into frustums.
|
What's the plan with #1340? Cleanup the ground layering? Do you also want to look into OIT before merging? |
There was a problem hiding this comment.
No need to rename now since this is so deep in the renderer, but my latest thinking (still formulating though) is that color/shadow/cubemap/pick/early-z/etc are "passes", and these are "stages" inside a pass.
|
Performance-wise, this is terrible for models, which already have all their commands in an array ready to go. Did I agree to this claiming that future changes with the material-aware commands will eliminate this bottleneck? I think that will be true. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the command list data structure with an array. Commands specify a pass and are separated when creating the potentially visible set and binned into frustums.
This is from #1340. It has been reviewed, tested, and is ready for master.