Fix typo in vertexPositions cartographicRadians processing #1662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add unit tests.
Contributor
There was a problem hiding this comment.
typo: vertextPostisions worth with
Contributor
Author
There was a problem hiding this comment.
Apparently you're not familiar with Newton's lesser known work, conservation of typos. For every one one I fix in the code, I have to add one somewhere else.
Contributor
Author
|
Okay, ready. I don't know what's wrong with my brain that it doesn't see such obvious typos. |
shunter
added a commit
that referenced
this pull request
Apr 29, 2014
…Radians Fix typo in vertexPositions cartographicRadians processing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add unit tests. CzmlDataSource.js and CzmlDataSourceSpec.js are both overdue for a much larger cleanup (which I hope to happen in the near term); so I just made the simplest fix possible for now.