Refactor

Author: sebastianbergmann

src/Directory.php

@@ -11,8 +11,20 @@
 
 final class Directory
 {
-    public static function create(string $directory): bool
+    /**
+     * @throws DirectoryCouldNotBeCreatedException
+     */
+    public static function create(string $directory): void
     {
-        return !(!\is_dir($directory) && !@\mkdir($directory, 0777, true) && !\is_dir($directory));
+        $success = !(!\is_dir($directory) && !@\mkdir($directory, 0777, true) && !\is_dir($directory));
+
+        if (!$success) {
+            throw new DirectoryCouldNotBeCreatedException(
+                \sprintf(
+                    'Directory "%s" could not be created',
+                    $directory
+                )
+            );
+        }
     }
 }

src/Exception/DirectoryCouldNotBeCreatedException.php

@@ -0,0 +1,14 @@
+<?php declare(strict_types=1);
+/*
+ * This file is part of phpunit/php-code-coverage.
+ *
+ * (c) Sebastian Bergmann <sebastian@phpunit.de>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+namespace SebastianBergmann\CodeCoverage;
+
+final class DirectoryCouldNotBeCreatedException extends RuntimeException
+{
+}

src/Report/Clover.php

@@ -237,9 +237,7 @@ public function process(CodeCoverage $coverage, ?string $target = null, ?string
         $buffer = $xmlDocument->saveXML();
 
         if ($target !== null) {
-            if (!Directory::create(\dirname($target))) {
-                throw new \RuntimeException(\sprintf('Directory "%s" was not created', \dirname($target)));
-            }
+            Directory::create(\dirname($target));
 
             if (@\file_put_contents($target, $buffer) === false) {
                 throw new RuntimeException(

src/Report/Crap4j.php

@@ -117,9 +117,7 @@ public function process(CodeCoverage $coverage, ?string $target = null, ?string
         $buffer = $document->saveXML();
 
         if ($target !== null) {
-            if (!Directory::create(\dirname($target))) {
-                throw new \RuntimeException(\sprintf('Directory "%s" was not created', \dirname($target)));
-            }
+            Directory::create(\dirname($target));
 
             if (@\file_put_contents($target, $buffer) === false) {
                 throw new RuntimeException(

src/Report/Html/Facade.php

@@ -90,18 +90,14 @@ public function process(CodeCoverage $coverage, string $target): void
             $id = $node->getId();
 
             if ($node instanceof DirectoryNode) {
-                if (!DirectoryUtil::create($target . $id)) {
-                    throw new \RuntimeException(\sprintf('Directory "%s" was not created', $target . $id));
-                }
+                DirectoryUtil::create($target . $id);
 
                 $directory->render($node, $target . $id . '/index.html');
                 $dashboard->render($node, $target . $id . '/dashboard.html');
             } else {
                 $dir = \dirname($target . $id);
 
-                if (!DirectoryUtil::create($dir)) {
-                    throw new \RuntimeException(\sprintf('Directory "%s" was not created', $dir));
-                }
+                DirectoryUtil::create($dir);
 
                 $file->render($node, $target . $id . '.html');
             }
@@ -145,14 +141,7 @@ private function getDirectory(string $directory): string
             $directory .= \DIRECTORY_SEPARATOR;
         }
 
-        if (!DirectoryUtil::create($directory)) {
-            throw new RuntimeException(
-                \sprintf(
-                    'Directory "%s" does not exist.',
-                    $directory
-                )
-            );
-        }
+        DirectoryUtil::create($directory);
 
         return $directory;
     }

src/Report/PHP.php

@@ -41,9 +41,7 @@ public function process(CodeCoverage $coverage, ?string $target = null): string
         );
 
         if ($target !== null) {
-            if (!Directory::create(\dirname($target))) {
-                throw new \RuntimeException(\sprintf('Directory "%s" was not created', \dirname($target)));
-            }
+            Directory::create(\dirname($target));
 
             if (@\file_put_contents($target, $buffer) === false) {
                 throw new RuntimeException(

src/Report/Xml/Facade.php

@@ -90,11 +90,9 @@ private function initTargetDirectory(string $directory): void
                     "'$directory' exists but is not writable."
                 );
             }
-        } elseif (!DirectoryUtil::create($directory)) {
-            throw new RuntimeException(
-                "'$directory' could not be created."
-            );
         }
+
+        DirectoryUtil::create($directory);
     }
 
     private function processDirectory(DirectoryNode $directory, Node $context): void