Skip to content

Code Review Workspace 1.10.0

Choose a tag to compare

@AndrewBird81 AndrewBird81 released this 01 Nov 17:55
· 139 commits to main since this release
Immutable release. Only release title and notes can be modified.

Other plugins read where each review stands with one call, and the lists say who a review waits on in more cases: comments out from a PR's review, your approval in the main thread, a Push under way, and a removed folder. Still BB 0.48+ (plugin SDK 0.6.79+) with Node 24+; installs at ^1.0.0 update to 1.10.0. 1.10.0 adds no migration: when each review came to stand as it does is kept with the review's other lifecycle fields. Rolling back to 1.9.0 keeps every review and setting, and 1.9.0 ignores that field; other plugins' calls of reviews.v1.status then answer unknown_method. As it starts, 1.10.0 ends an approval sent to a main thread for a diff its review no longer shows, as 1.9.0 kept one after Update, and Finish review offers Send approval for that review again, on 1.9.0 too.

For other plugins

  • reviews.v1.status, a typed method published to BB's RPC discovery, lists every review with who it waits on, user, agent and the thread working on it, author or nobody, whether you've approved the code as it is now, since when, its status as All reviews says it, and the PR, branch, folder and threads it belongs to. A review merged into another names the one that stays. It reads no diff or guide, so it's cheap to poll, and it says what All reviews, the alerts and bb review list say. docs/plugin-api.md is its contract: within v1 a field may be added, never removed or changed in meaning. listReviews and the panel's other methods keep their fields, and stay the panel's own.
  • A plugin tells whether it's there by calling it: before 1.10.0 the call answers HTTP 404, unknown_method. bb plugin rpc inspect code-review-workspace reviews.v1.status prints its schemas, each field described.

Who a review waits on

  • Comments you send from a PR's review, your own or someone else's, a folder's review that became its PR's among them, wait on the thread fixing them, under Waiting on author as "2 of 6 reported", as a local review's do, where the review stayed in Needs review as Your PR or Ready, or in Reviewed. Something newer that's yours brings it back: a teammate's comment on your PR, a re-request, a question; and your next review on GitHub is the turn, as before.
  • An approval you send to the main thread of a local review or your own PR moves the review to Reviewed, Approved, "You approved 2h ago", where it stayed in Needs review. It holds while the code is as you approved it: the folder changing since, as the review checks it when the main thread stops, or new commits on the PR, bring the review back, and so does something newer that's yours, as a teammate's comment. Update, or any new diff, ends the approval, where it was kept and an older diff's approval read as current. A local review that becomes its PR's keeps it when the PR changes the same files the same way, as after Push.
  • A Push under way waits on the main thread, Committing for Push, then Pushing to feat/qa, under Waiting on author, where the review kept the turn it had.
  • A local review whose folder BB removed, with comments still open or sent, waits on no one, Folder removed under Waiting on author, where it stayed in Needs review. Comments that came back from its main thread, or whose thread was archived or deleted first, still bring it to Needs review.