Repository navigation
Code Review Workspace 1.12.0
One review of a PR and your local changes to it, comments that go to the thread that asked, a discussion with the agent you can see into and go on with, and a Finish review whose signals agree and that no longer asks about chapters you read quickly. Still BB 0.48+ (plugin SDK 0.6.79+) with Node 24+; installs at ^1.0.0 update to 1.12.0. 1.12.0 adds one migration, a chapter_reads table, on SQLite and on Postgres; what else it adds is kept with the review's other lifecycle fields and its draft. Rolling back to 1.11.0 keeps every review and setting, and deferrals you confirmed, how long chapters were open and It's fine unused until you update again, except that a draft 1.11.0 changes forgets which of the agent's comments you haven't seen, so they no longer say New from agent; on 1.11.0, bb review storage won't move the reviews between SQLite and Postgres, the migration being newer than it. There a folder that joined someone else's PR's review counts as yours, so Sends to its thread don't ask, comments sent to it don't post with Submit, and Push isn't offered; and a Deferred check shows a blank badge.
Your threads and your local changes
- A sub-thread's review goes to that sub-thread.
bb reviewwith no arguments, or Review changes above its message box, makes the thread you see that asked the review's main thread, even where an orchestrator works in the same folder: its comments, Send now, Main thread ↗ and the review's name are the sub-thread's, and the orchestrator no longer relays them. A hidden subagent's call still goes to the nearest thread you see working in that folder, and a thread working under one of the plugin's agents still can't start a review. A review an orchestrator already has keeps it; Change thread on its Main thread tab moves it to the sub-thread. Where sibling sub-threads work in one folder, their shared parent there is the main thread, as soon as a second of them works there, so no sibling takes the others' comments; the threads over a main thread aren't listed as also editing its folder. - Review changes, or
bb reviewwith no arguments, in a thread on the branch of an open PR you're reviewing already, as a thread you had check out a teammate's PR to change it, joins the PR's review. It started a review of its own beside it, with a second guide writer and review agent, which merged only on your click, and kept itself rather than the PR's. Now the folder is attached to the PR's review, the thread becomes its main thread, the one before kept, nothing is rebuilt, and Review changes opens the review on Not pushed yet: what the folder has that the PR's head on GitHub doesn't, committed or not. It joins the review of the PR PR Status names for the branch, else of the repo's open PR whose head is the branch, not from a fork, while the review has a guide, or one being written, and no folder of its own, and the folder has the PR's head; otherwise the folder gets a review of its own, as before. - It's still the author's PR: comments you send to the thread post with Submit unless you resolve or dismiss them, and a Send quotes the author's code as theirs. A Send to your thread there doesn't ask first, as Sends on someone else's PR do.
- Push works there, from the folder, and says first "This is @dana's PR: Push puts the commit on their branch,
feat/qa. Push anyway to go on.", with Push anyway and Cancel. A head in someone's fork goes to that fork's remote. Let it push when done on a Send asks first there too, and a Send that lets the thread push tells it whose branch a push changes. - The review agent is told the folder joined the review, where its instructions said a PR's review with a folder began as it. The skill agents in your threads read says to run
bb reviewthere for you to see their local changes to a PR.reviewThreadChangesanswersjoined: truewhen the folder joined.
Discussions with the agent
- Ask agent on a comment or the summary says what the agent gets with your words: "It sees this comment and line 192.", "It sees lines 1–2.", or "It sees the summary and the draft comments."
- "Agent edited the comment." and "Agent edited the summary." have Show changes, which strikes the words the edit took out and marks the ones it put in.
- The agent answers each question you ask in a discussion, and after an edit says in a sentence what it changed, where it could skip a reply before.
- A discussion with the agent ends with Reply, as a GitHub thread does: under a line, in Comments, and under the summary. Ask agent sat above it, among the comment's actions, so it didn't look like you could go on. Reply's box opens in its place, and the focus comes back to Reply once you send or leave it; Ask agent shows until there's a discussion.
- "The agent didn’t reply here." links to the agent's chat as Open its chat, which said Ask agent and read like Reply.
- Dig deeper says what it found once it's done, where the button was: each What to verify item marked holds ✓, problem ⚠ or not verified ?, with the agent's one-line note, its one line overall, the comments it added, each showing its line, and Agent’s reply, which opens its chat. It stays until you Dig deeper again, and says so when the agent stopped before it finished. The review agent reports it with a new tool,
report_deep_dive.
What the agent posts
- The review agent is told the PR's author reads the comments, replies and summary on GitHub and never sees the guide, in a review pass, a re-review's check and Dig deeper, so what it drafts no longer mentions its chapters, Start here, risk levels or what it flagged, which read on GitHub as a reply to a conversation the author never had. A problem the guide pointed to that the agent verifies is still a comment, on its own evidence; a spot that holds up, it tells you in chat.
- The agent raises a finding about a line as a line comment before its summary names it, a re-review's new findings too, so you meet it reading the chapters, and the summary raises nothing they didn't. Under the summary in Finish review, each changed line it cites, such as
playlist.go:192, opens in the code, marked with the severity of the comment there, or Not in your comments when no comment raises it. - A comment the agent adds, in its review, a re-review or while it updates the summary at your ask, is New from agent—not yet reviewed: on its card in the code and in Comments, its pill and row, and on the chip of a summary that cites it. It stays marked until its card has been in view for a moment, or you edit it, on every device, so a finding added at the summary doesn't pass as one you read in the chapters.
Finish review
- While Finish review is open, Submit to GitHub is the one filled button: the last chapter's end and Not pushed yet's drop their Finish review, Mark viewed and finish reads Mark viewed, and every other button that was filled is outlined: every chapter's buttons, the Overview's way in, Send reply, the comment box's Save, Send and Let it push for the main thread, Update first, and the confirms of Move to summary, Replace summary and a notice's recommended choice. On a local review, with no Submit, Send to the main thread stays filled. Finish review in BB's title bar opens the panel, or takes you to it, and never closes it, where a second click closed it. Under Submit, "Your draft stays in BB until you submit, then posts to
flosports/web#4512as @you." A reviewer who saw Finish review beside Submit to GitHub couldn't tell which came first, or whether finishing would close the review before they'd submitted. - On a re-review, the agent's read count is of the files changed since your review, "Read 1 of 2 files changed since your review", and what it read with
read_changes_since_reviewcounts, where it said "Read 0 of 8 files". After a rebase alone it says nothing. - The agent can't suggest Approve while a blocking item is open or unchecked, from its check or
set_review_summary, and a later check that reopens one withdraws the Approve it suggested before, so Finish review no longer shows "Agent suggests Approve" beside Request what's left. A new verdict, Deferred, is for an ask the author, the PR or you say comes later, as in a follow-up PR, quoting where. It's the agent's proposal: "Deferred · not confirmed", in Needs you, still blocks an Approve and stays in Request what's left until you click Confirm deferral on it in Comments (Reopen takes it back). Confirmed, it leaves Needs you and Request what's left, a review with the rest addressed looks ready, and a row's progress says it apart, "1/2 addressed +1 deferred". Request what's left's summary is yours, "Summary · not submitted". - Your last review is history, not a status: "Your last review: Commented · 5h ago · 2 commits since", neutral, with View on GitHub.
- Before you approve, a part of Finish review between Verdict and Goes to GitHub while you approve, lists files in high-risk chapters you haven't viewed and, new, flagged files you haven't viewed: a test that loses assertions or skips tests, a lockfile with a new download host, or hidden bidirectional Unicode ("1 flagged file not viewed: tests weakened."), each with Show, and an Approve the agent suggests without reading every file. Submit asks once more about these. They were under Goes to GitHub, though none of them posts.
- Chapters marked viewed faster than they read are one plain row there, where each was a warning: "Read quickly: chapters 2 and 3 · 373 lines in 2 min", with the riskiest one's first thing to check under it and Show, which opens that chapter. Submit no longer asks about them.
- Tests and docs read at their own pace, 2,000 lines an hour by default, beside 500 for code and config; lockfiles and generated files still don't count. A chapter is judged once all its files to read are viewed, and only when it takes 6 minutes or more at those paces, where it was 50 lines at any pace: 67 lines of tests marked viewed in a minute no longer count as read too fast.
- A chapter's reading time is the longer of the time between your Viewed marks and how long it was open in a window you could see, kept on the server, so every device counts it. It only ever takes a chapter off the list.
- When Mark viewed and continue, Mark chapter viewed, or a file's Viewed finishes a medium- or high-risk chapter faster than its pace, the toast says so ("Chapter 3 went quickly for high risk."), with Back to it, which opens the chapter again, its files unfolded. The chapter says so too, above What to verify, "Read quickly · 237 lines in 1 min", with It's fine. The line goes once the chapter has been open long enough at your pace; It's fine takes it off Finish review's list too, on every device, until you mark the chapter viewed again.
- Settings → Check before you approve has Reading pace: Code and config, 100 to 2,000 lines an hour, 500 by default, which was Flag chapters read faster than, and Tests and Docs, 100 to 10,000, 2,000 by default. Those two are saved only while they differ from their defaults, so a release that tunes them reaches you.