Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor clients #61

Merged
merged 5 commits into from
May 23, 2020
Merged

Refactor clients #61

merged 5 commits into from
May 23, 2020

Conversation

Archomeda
Copy link
Owner

This refactors the clients to:

  • Remove the generic type from ILocalizedClient since it wasn't used
  • Remove the IClient and IInternalClient interfaces
  • Repurpose BaseClient into Gw2WebApiBaseClient
  • Remove the redundant parameters for the Gw2MumbleClient constructor

Closes #57

@Archomeda Archomeda added Area: Web API v2 Related to the v2 web API Type: Refactor An improvement to the project that doesn't necessarily add a new features labels May 23, 2020
@Archomeda Archomeda merged commit ea8195d into master May 23, 2020
@Archomeda Archomeda deleted the refactor/clients branch May 23, 2020 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Web API v2 Related to the v2 web API Type: Refactor An improvement to the project that doesn't necessarily add a new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Look into removing the generic type in ILocalizedClient
1 participant
@Archomeda