bugfix BLE legacy advertisements broken #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tridge I tested it again with the last master build. It fails detecting the Remote ID signals very soon. With my professional receiver it keeps receiving signals. So I guess it has to do with the BT4/5 stack of the phone that doesn't seem to be able to handle multiple BT4 advertisements (crashes). Your Samsung S10 does a better job. This PR is basically a work-around for phones with buggy BT4 implementation. As most phones don't have BT5 support, having a BT4 implementation that can be received my most phones is important. |
|
I've fixed conflicts with previous PRs, and tested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation, BLE4 legacy transmission work for about 30 seconds. Then it crashes and no BT4 legacy packets can be received anymore.
The "issue" seems to be caused the separate BLE legacy advertisement service for the BLE device name. This was also solved in this PR #26 but due to parallel code development at that time, this part wasn't included. The solution is to incorporate the BLE device name broadcast into the regular BT4 transmissions. Not sure what the underlying issue is, perhaps it is just a bug in the ESP/Arduino environment.