Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copter/Rover: vision-position support should be moved to AP_VisualOdom #8061

Closed
rmackay9 opened this issue Apr 2, 2018 · 2 comments
Closed
Assignees

Comments

@rmackay9
Copy link
Contributor

rmackay9 commented Apr 2, 2018

Copter-3.6 and Rover-3.3 can consume these external position estimate messages:

These are then passed into the EKF by GCS_MAVLink library but this functionality should be moved to the AP_VisualOdometry library because:

  • we need the camera offset position which is held in AP_VisualOdometry
  • the messages are quite similar

This would also allow us to add a parameter to control whether the message's system time is used or the flight controller's time (held in the message) should be used.

@rmackay9
Copy link
Contributor Author

rmackay9 commented Apr 4, 2018

I think @peterbarker says he'll take this on

@rmackay9
Copy link
Contributor Author

This has been done now in master so closing, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants