-
Notifications
You must be signed in to change notification settings - Fork 17k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RC_Channel: input value watchdog #10205
RC_Channel: input value watchdog #10205
Conversation
I don't see how this is actually useful, requires you to be moving every channel constantly, even your switches/flight mode channel/things you aren't mixing. |
@WickedShell, thanks for taking a look. This is the optional safety feature that can be useful for someone; but unfortunately I don't see a way to make it good for everyone.
I understand the current solution is not ideal. Any ideas of how that could be improved further are really welcome! |
How about a simpler solution - no channel mask, just checking that we have seen at least one channel change value in the last seconds. Any channel specified as an RSSI channel would be ignored for this check. This would catch the case where someone has not set up throttle failsafe appropriately and their receiver reverts its outputs to the bind values, but without a tell-tale throttle value. I'm marking as devcall so we can decide whether any such feature is desired... |
So, during a mission where you take off manually and you can be looking at the grass grow this could kick in if misconfigured......I know setting to zero disables it.....but..... |
On Fri, 12 Apr 2019, Luis Vale Gonçalves wrote:
So, during a mission where you take off manually and you can be looking at the grass grow this could kick in if misconfigured......I know setting to zero
disables it.....but.....
It's relying on the small amount of noise you usually see on RC input.
Yes, that's a problem if you happen to have a very clean RC signal
somehow.
Having your RC transmitter able to produce a sine wave on a channel would
be ideal.... but if you're able to set that up you're probably able to set
up a throttle failsafe properly ('though this scheme also helps if the
receiver malfunctions in that case).
|
If you zoom in on those flat sections it really does stay perfectly undisturbed, and the RC transmitter is powered on/connected. Clean RC is trivial to get if you use any of the digital input protocols and are flying autonomously (heck even Cruise is easy to be idle that long). I won't block, but it certainly has to be an off by default feature. I still don't like it, as it seems to just be trying to accommodate badly setup receivers/unsafe ones. |
I agree with @WickedShell If we start going after every marginal setup it's never going to end. |
Modern RC’s are locked it, this is not a great option sorry. |
I don't like this - it is so dependent on equipment (and depends on bad equipment!), and is bound to produce false positives |
Impl. for #5375
Personally I've never faced such issues but there is a real risk exists taking into account RC receivers are complex devices and some Vendors does publish not very stable firmware.
It is supposed that user will set the TIMEOUT parameter for one or several channels so they will be monitored. And if any of the monitored channels got stuck with the exact same value then Radio FS should kick in.